You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Hester Gong 8120c0c20c
Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (#23513)
Close #23466

Right now on pull request "files Changed" tab, if a file is viewed, when
the comments' links are visited, the comment will not be shown as the
file is folded after viewed. This PR is to improve the behavior, to make
the comment seen even the related file is folded, like on github.

And right now scroll position will be remembered and hence it won’t
scroll to hashed comment after refreshing, this PR also adjust the
scroll position remembering behavior: When there is hash comment in url,
do not remember the scroll position.

Before:

https://user-images.githubusercontent.com/17645053/225512079-6cf79581-9346-44cf-95d6-06919642e6a8.mov

After:

https://user-images.githubusercontent.com/17645053/225523753-3f6728f2-977b-4ed0-a65c-63dcef2ace80.mov

Update - long comment's behavior after using `scrollTop ` (Comment div
scroll to the position which is 30px below the diff header, or 30px
below top on conversation tab):

https://user-images.githubusercontent.com/17645053/225614460-0602c1a6-229c-41f4-84d2-334e78251486.mov
1 year ago
..
components Remove stars in dashboard repo list (#23530) 1 year ago
features Imrove scroll behavior to hash issuecomment(scroll position, auto expand if file is folded, and on refreshing) (#23513) 1 year ago
markup update to mermaid v10 (#23178) 1 year ago
modules Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 1 year ago
standalone Add new JS linter rules (#17699) 3 years ago
test Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2 years ago
utils Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
webcomponents Add document for `webcomponents` (#23261) 1 year ago
bootstrap.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) 2 years ago
index.js Refactor dashboard repo list to Vue SFC (#23405) 1 year ago
jquery.js Upgrade jQuery to 3.5.0, remove jQuery-Migrate, fix deprecations (#11055) 4 years ago
serviceworker.js Fix serviceworker output file and misc improvements (#11562) 4 years ago
svg.js Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
svg.test.js Remove vitest globals (#21505) 2 years ago
utils.js Scoped labels (#22585) 1 year ago
utils.test.js Fix links for the menus in the view file page (#22795) 2 years ago