You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/services
zeripath b091c994b5
Comments on review should have the same sha (#13448)
* When replying to an outdated comment it should not appear on the files page

This happened because the comment took the latest commitID as its base instead of the
reviewID that it was replying to.

There was also no way of creating an already outdated comment - and a
reply to a review on an outdated line should be outdated.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix test

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Fix broken migration

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* Create temporary table because ... well MSSQL ...

Signed-off-by: Andrew Thornton <art27@cantab.net>

* fix mssql

Signed-off-by: Andrew Thornton <art27@cantab.net>

* move session within the batch

Signed-off-by: Andrew Thornton <art27@cantab.net>

* regen the sqlcmd each time round the loop

Signed-off-by: Andrew Thornton <art27@cantab.net>

* as per @lunny

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
4 years ago
..
archiver [RFC] Make archival asynchronous (#11296) 4 years ago
comments Refactor pull request review (#8954) 5 years ago
externalaccount Allow externalID to be UUID (#8551) 5 years ago
gitdiff Alternative fix for HTML diff entity split (#13425) 4 years ago
issue Add review request api (#11355) 4 years ago
mailer Fix "only mail on mention" bug (#12775) 4 years ago
mirror Refactor: Move PushUpdateOptions (#13363) 4 years ago
pull Comments on review should have the same sha (#13448) 4 years ago
release Add the tag list page to the release page (#12096) 4 years ago
repository Fix a bug on refactoring (#13373) 4 years ago
wiki Update golangci-lint to version 1.31.0 (#13102) 4 years ago