meissa
/
forgejo
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '96be0cb6e3'
${ noResults }
forgejo/web_src/js/features
History
wxiaoguang 345aa09756
Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 
This PR is extracted from #23346 to address some unclear (I don't
understand) code-belonging concerns.

This PR needs to be backported, otherwise the `aria.js` is too buggy in
some cases. Since there would be two minor conflicts, I will do the
backport manually.

Before: the `aria.js` is still buggy in some cases.

After: tested with AppleVoice, Android TalkBack

* Fix incorrect dropdown init code
* Fix incorrect role element (the menu role should be on the `$menu`
element, but not on the `$focusable`)
* Fix the focus-show-click-hide problem on mobile. Now the language menu
works as expected
* Fix incorrect dropdown template function setting
* Clarify the logic in aria.js
* Hide item's tippy after menu gets hidden
* Fix incorrect tippy `setProps` after `destroy`
* Fix UI lag problem when page gets redirected during menu hiding
animation with screen reader
* Improve comments
* Implement the layout proposed by #19861

<details>


d74a7efb60/web_src/js/features/aria.md?plain=1#L38-L47

</details>
 		1 year ago
..
admin Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
comp Scoped labels: set aria-disabled on muted Exclusive option for a11y (#23306) 1 year ago
aria.js Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 1 year ago
aria.md Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 1 year ago
captcha.js Add new captcha: cloudflare turnstile (#22369) 1 year ago
citation.js Fix switched citation format (#23250) 1 year ago
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
codeeditor.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) 2 years ago
colorpicker.js JS refactors (#22227) 2 years ago
common-global.js Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 1 year ago
common-issue.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
common-organization.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
contextpopup.js Change interactiveBorder to fix popup preview (#23169) 1 year ago
copycontent.js JS refactors (#22227) 2 years ago
dropzone.js JS refactors (#22227) 2 years ago
emoji.js JS refactors (#22227) 2 years ago
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2 years ago
file-fold.js JS refactors (#22227) 2 years ago
formatting.js JS refactors (#22227) 2 years ago
heatmap.js JS refactors (#22227) 2 years ago
imagediff.js Fix various ImageDiff/SVG bugs (#23312) 1 year ago
install.js Fix various bugs for "install" page (#23194) 1 year ago
notification.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
org-team.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
pull-view-file.js Replace unstyled meter with progress (#19968) 2 years ago
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2 years ago
repo-code.js Fix links for the menus in the view file page (#22795) 1 year ago
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) 2 years ago
repo-commit.js Fix hidden commit status on multiple checks (#22889) 1 year ago
repo-common.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-diff-filetree.js JS refactors (#22227) 2 years ago
repo-diff.js Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 1 year ago
repo-editor.js Support paste treepath when creating a new file or updating the file name (#23209) 1 year ago
repo-findfile.js Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
repo-findfile.test.js Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
repo-graph.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-home.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-issue-content.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-issue-pr-form.js JS refactors (#22227) 2 years ago
repo-issue.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
repo-legacy.js Fix aria.js bugs: incorrect role element problem, mobile focus problem, tippy problem (#23450) 1 year ago
repo-migrate.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-migration.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-projects.js Sync the class change of Edit Column Button to JS code (#23400) 1 year ago
repo-release.js Hide target selector if tag exists when creating new release (#23171) 1 year ago
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2 years ago
repo-template.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-unicode-escape.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2 years ago
serviceworker.js JS refactors (#22227) 2 years ago
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 3 years ago
stopwatch.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
tablesort.js JS refactors (#22227) 2 years ago
tribute.js JS refactors (#22227) 2 years ago
user-auth-webauthn.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-auth.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-settings.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago