You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qwerty287 9d943bf374
Add missing `X-Total-Count` and fix some related bugs (#17968)
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
3 years ago
..
app.go Move login related structs and functions to models/login (#17093) 3 years ago
email.go Move EmailAddress & UserRedirect into models/user/ (#17607) 3 years ago
follower.go Move user related model into models/user (#17781) 3 years ago
gpg_key.go Move keys to models/asymkey (#17917) 3 years ago
helper.go Move user related model into models/user (#17781) 3 years ago
key.go Move keys to models/asymkey (#17917) 3 years ago
repo.go Move repository model into models/repo (#17933) 3 years ago
settings.go Fix database inconsistent when admin change user email (#17549) 3 years ago
star.go Add missing `X-Total-Count` and fix some related bugs (#17968) 3 years ago
user.go Move user related model into models/user (#17781) 3 years ago
watch.go Some repository refactors (#17950) 3 years ago