meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '9d943bf374'
${ noResults }
forgejo/routers/web/repo
History
qwerty287 9d943bf374
Add missing `X-Total-Count` and fix some related bugs (#17968) 
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
 		3 years ago
..
activity.go Move unit into models/unit/ (#17576) 3 years ago
attachment.go Move attachment into models/repo/ (#17650) 3 years ago
blame.go Move repository model into models/repo (#17933) 3 years ago
branch.go Some repository refactors (#17950) 3 years ago
commit.go Add missing `X-Total-Count` and fix some related bugs (#17968) 3 years ago
compare.go Some repository refactors (#17950) 3 years ago
download.go Move repository model into models/repo (#17933) 3 years ago
editor.go Clean legacy SimpleMDE code (#17926) 3 years ago
editor_test.go Decouple unit test code from business code (#17623) 3 years ago
http.go Some repository refactors (#17950) 3 years ago
http_test.go Fix http path bug (#16117) 3 years ago
issue.go Some repository refactors (#17950) 3 years ago
issue_content_history.go Move unit into models/unit/ (#17576) 3 years ago
issue_dependency.go Rename context.Query to context.Form (#16562) 3 years ago
issue_label.go Use a standalone struct name for Organization (#17632) 3 years ago
issue_label_test.go Decouple unit test, remove intermediate `unittestbridge` package (#17662) 3 years ago
issue_lock.go Refactor routers directory (#15800) 3 years ago
issue_stopwatch.go Multiple Escaping Improvements (#17551) 3 years ago
issue_test.go A better go code formatter, and now `make fmt` can run in Windows (#17684) 3 years ago
issue_timetrack.go Refactor routers directory (#15800) 3 years ago
issue_watch.go Refactor routers directory (#15800) 3 years ago
lfs.go Move repository model into models/repo (#17933) 3 years ago
main_test.go Decouple unit test code from business code (#17623) 3 years ago
middlewares.go Move user related model into models/user (#17781) 3 years ago
migrate.go Some repository refactors (#17950) 3 years ago
milestone.go Multiple Escaping Improvements (#17551) 3 years ago
projects.go Support sorting for project board issuses (#17152) 3 years ago
projects_test.go Decouple unit test code from business code (#17623) 3 years ago
pull.go Add missing `X-Total-Count` and fix some related bugs (#17968) 3 years ago
pull_review.go Rename ctx.Form() to ctx.FormString() and move code into own file (#16571) 3 years ago
release.go Clean legacy SimpleMDE code (#17926) 3 years ago
release_test.go Decouple unit test, remove intermediate `unittestbridge` package (#17662) 3 years ago
repo.go Some repository refactors (#17950) 3 years ago
search.go Related refactors to ctx.FormX functions (#16567) 3 years ago
setting.go Return nicer error for ForcePrivate (#17971) 3 years ago
setting_protected_branch.go Move repository model into models/repo (#17933) 3 years ago
settings_test.go Move keys to models/asymkey (#17917) 3 years ago
tag.go Move repository model into models/repo (#17933) 3 years ago
topic.go Some repository refactors (#17950) 3 years ago
view.go Add missing `X-Total-Count` and fix some related bugs (#17968) 3 years ago
webhook.go Move accessmode into models/perm (#17828) 3 years ago
wiki.go Clean legacy SimpleMDE code (#17926) 3 years ago
wiki_test.go Move repository model into models/repo (#17933) 3 years ago