You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Kyle Evans 38cd9ba47b
Allow unauthenticated users to compare (#11240)
* routers: make /compare route available to unauthenticated users

Remove some bits of the compare interface if the user isn't signed in.
Notably, they don't need to see the "New Pull Request" button box nor the
hidden form that would fail to submit due to the POST request continuing to
require proper privileges.

Follow-up commits will improve the UI a bit around this, removing some
"Pull Request" verbiage in favor of "Compare."

* ui: home: show "compare" button for unauthenticated users

This change requires pulling in the BaseRepo unconditionally and
recording if the pull request is in-fact not allowed
(.PullRequestCtx.Allowed). If the user isn't allowed to create a pull
request, either because this isn't a fork or same-fork branch PRs aren't
allowed, then we'll name the button "Compare" instead of "Pull Request."

* ui: branch list: use the new Compare language when available

When viewing the branch listing as an unauthenticated user, you'll get
"Pull Request" buttons. use the new "Compare" verbiage instead, which
matches GitHub behavior when you can't issue a pull request from the
branches.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
4 years ago
..
blob_excerpt.tmpl Fix and simplify some tmpl conditions (#11080) 4 years ago
box.tmpl Add a way to mark Conversation (code comment) resolved (#11037) 4 years ago
comment_form.tmpl Fix reply on code review (#10227) 4 years ago
comment_form_datahandler.tmpl Pull request review/approval and comment on code (#3748) 6 years ago
comments.tmpl Remove last traces of has-emoji class (#11263) 4 years ago
compare.tmpl Allow unauthenticated users to compare (#11240) 4 years ago
image_diff.tmpl Bugfix for image compare and minor improvements to image compare (#8289) 5 years ago
new_comment.tmpl Pull request review/approval and comment on code (#3748) 6 years ago
new_review.tmpl Fix submit review form (#11252) 4 years ago
options_dropdown.tmpl FIX download diff/patch from commit (#8792) 5 years ago
section_unified.tmpl Add a way to mark Conversation (code comment) resolved (#11037) 4 years ago
whitespace_dropdown.tmpl Add whitespace handling to PR-comparsion (#4683) 6 years ago