You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 858c35b731
Ensure BlameReaders close at end of request (#12102)
#11716 reports multiple git blame processes hanging around
this was thought to be due to timeouts, however on closer look this
appears to be due to the Close() function of the BlameReader hanging
with a blocked stdout pipe.

This PR fixes this Close function to:

* Cancel the context of the cmd
* Close the StdoutReader - ensuring that the output pipe is closed

Further it makes the context of the `git blame` command a child of the
request context - ensuring that even if Close() is not called, on
cancellation of the Request the blame is command will also be cancelled.

Fixes #11716
Closes #11727

Signed-off-by: Andrew Thornton <art27@cantab.net>
4 years ago
..
activity.go Add top author stats to activity page (#9615) 5 years ago
attachment.go Move dropzone.js to npm/webpack (#10645) 4 years ago
blame.go Ensure BlameReaders close at end of request (#12102) 4 years ago
branch.go Handle more pathological branch and tag names (#11843) 4 years ago
commit.go Show exact tag for commit on diff view (#11846) 4 years ago
compare.go Server-side syntax highlighting for all code (#12047) 4 years ago
download.go Fix download file wrong content-type (#9825) 5 years ago
editor.go Fix numbr of files, total additions, and deletions (#11614) 4 years ago
editor_test.go Add Close() method to gogitRepository (#8901) 5 years ago
http.go fix a small nit (#11834) 4 years ago
issue.go Add push commits history comment on PR time-line (#11167) 4 years ago
issue_dependency.go Fix wrong permissions check when issues/prs shared operations (#9885) 5 years ago
issue_label.go Add Organization Wide Labels (#10814) 4 years ago
issue_label_test.go fix go vet error (#3740) 6 years ago
issue_lock.go Implement "conversation lock" for issue comments (#5073) 5 years ago
issue_stopwatch.go Automatically clear stopwatch on merging a PR (#4327) 5 years ago
issue_timetrack.go [API] Extend times API (#9200) 5 years ago
issue_watch.go Fix PR/issue redirects when having external tracker (#9339) 5 years ago
lfs.go Migrate to go-git/go-git v5.0.0 (#10735) 4 years ago
main_test.go Unit tests for wiki routers (#3022) 7 years ago
middlewares.go Add gitea-vet (#10948) 4 years ago
milestone.go Show description on individual milestone view (#12055) 4 years ago
pull.go Handle more pathological branch and tag names (#11843) 4 years ago
pull_review.go Add a way to mark Conversation (code comment) resolved (#11037) 4 years ago
release.go Honor DEFAULT_PAGING_NUM for API (#11805) 4 years ago
release_test.go Add Close() method to gogitRepository (#8901) 5 years ago
repo.go Global default branch setting (#11918) 4 years ago
search.go Add detected file language to code search (#10256) 4 years ago
setting.go Fix doer of rename repo (#11789) 4 years ago
setting_protected_branch.go Prevent merge of outdated PRs on protected branches (#11012) 4 years ago
settings_test.go Stop various tests from adding to the source tree (#9515) 5 years ago
topic.go Add API endpoint for accessing repo topics (#7963) 5 years ago
view.go Server-side syntax highlighting for all code (#12047) 4 years ago
webhook.go Fix webhook template when validation errors occur (#11421) 4 years ago
wiki.go Allow different HardBreaks settings for documents and comments (#11515) 4 years ago
wiki_test.go Fix wiki raw view on sub path (#10002) 4 years ago