You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
6e22605793
As recognised in #21841 the rendering of plain text files is somewhat incorrect when there are ambiguous characters as the html code is double escaped. In fact there are several more problems here. We have a residual isRenderedHTML which is actually simply escaping the file - not rendering it. This is badly named and gives the wrong impression. There is also unusual behaviour whether the file is called a Readme or not and there is no way to get to the source code if the file is called README. In reality what should happen is different depending on whether the file is being rendered a README at the bottom of the directory view or not. 1. If it is rendered as a README on a directory - it should simply be escaped and rendered as `<pre>` text. 2. If it is rendered as a file then it should be rendered as source code. This PR therefore does: 1. Rename IsRenderedHTML to IsPlainText 2. Readme files rendered at the bottom of the directory are rendered without line numbers 3. Otherwise plain text files are rendered as source code. Replace #21841 Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> |
2 years ago | |
|---|---|---|
| .. | ||
| ambiguous | 2 years ago | |
| invisible | 2 years ago | |
| ambiguous.go | 2 years ago | |
| ambiguous_gen.go | 2 years ago | |
| ambiguous_gen_test.go | 2 years ago | |
| breakwriter.go | 2 years ago | |
| breakwriter_test.go | 2 years ago | |
| charset.go | 2 years ago | |
| charset_test.go | 2 years ago | |
| escape.go | 2 years ago | |
| escape_status.go | 2 years ago | |
| escape_stream.go | 2 years ago | |
| escape_test.go | 2 years ago | |
| htmlstream.go | 2 years ago | |
| invisible_gen.go | 2 years ago | |