You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
4562d40fce
* fix hard-coded timeout and error panic in API archive download endpoint
This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}`
endpoint which prior to this PR had a couple of issues.
1. The endpoint had a hard-coded 20s timeout for the archiver to complete after
which a 500 (Internal Server Error) was returned to client. For a scripted
API client there was no clear way of telling that the operation timed out and
that it should retry.
2. Whenever the timeout _did occur_, the code used to panic. This was caused by
the API endpoint "delegating" to the same call path as the web, which uses a
slightly different way of reporting errors (HTML rather than JSON for
example).
More specifically, `api/v1/repo/file.go#GetArchive` just called through to
`web/repo/repo.go#Download`, which expects the `Context` to have a `Render`
field set, but which is `nil` for API calls. Hence, a `nil` pointer error.
The code addresses (1) by dropping the hard-coded timeout. Instead, any
timeout/cancelation on the incoming `Context` is used.
The code addresses (2) by updating the API endpoint to use a separate call path
for the API-triggered archive download. This avoids producing HTML-errors on
errors (it now produces JSON errors).
Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
|
2 years ago | |
|---|---|---|
| .. | ||
| activity.go | 2 years ago | |
| attachment.go | 2 years ago | |
| blame.go | 2 years ago | |
| branch.go | 2 years ago | |
| cherry_pick.go | 2 years ago | |
| commit.go | 2 years ago | |
| compare.go | 2 years ago | |
| download.go | 2 years ago | |
| editor.go | 2 years ago | |
| editor_test.go | 2 years ago | |
| find.go | 2 years ago | |
| http.go | 2 years ago | |
| http_test.go | 3 years ago | |
| issue.go | 2 years ago | |
| issue_content_history.go | 2 years ago | |
| issue_dependency.go | 2 years ago | |
| issue_label.go | 2 years ago | |
| issue_label_test.go | 2 years ago | |
| issue_lock.go | 2 years ago | |
| issue_stopwatch.go | 2 years ago | |
| issue_test.go | 2 years ago | |
| issue_timetrack.go | 2 years ago | |
| issue_watch.go | 2 years ago | |
| lfs.go | 2 years ago | |
| main_test.go | 2 years ago | |
| middlewares.go | 2 years ago | |
| migrate.go | 2 years ago | |
| milestone.go | 2 years ago | |
| packages.go | 2 years ago | |
| patch.go | 2 years ago | |
| projects.go | 2 years ago | |
| projects_test.go | 3 years ago | |
| pull.go | 2 years ago | |
| pull_review.go | 2 years ago | |
| release.go | 2 years ago | |
| release_test.go | 2 years ago | |
| render.go | 2 years ago | |
| repo.go | 2 years ago | |
| search.go | 2 years ago | |
| setting.go | 2 years ago | |
| setting_protected_branch.go | 2 years ago | |
| settings_test.go | 2 years ago | |
| tag.go | 2 years ago | |
| topic.go | 2 years ago | |
| treelist.go | 2 years ago | |
| view.go | 2 years ago | |
| view_test.go | 2 years ago | |
| webhook.go | 2 years ago | |
| wiki.go | 2 years ago | |
| wiki_test.go | 2 years ago | |