You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
This follows * https://github.com/go-gitea/gitea/issues/18553 Introduce `RunWithContextString` and `RunWithContextBytes` to help the refactoring. Add related unit tests. They keep the same behavior to save stderr into err.Error() as `RunInXxx` before. Remove `RunInDirTimeoutPipeline` `RunInDirTimeoutFullPipeline` `RunInDirTimeout` `RunInDirTimeoutEnv` `RunInDirPipeline` `RunInDirFullPipeline` `RunTimeout`, `RunInDirTimeoutEnvPipeline`, `RunInDirTimeoutEnvFullPipeline`, `RunInDirTimeoutEnvFullPipelineFunc`. Then remaining `RunInDir` `RunInDirBytes` `RunInDirWithEnv` can be easily refactored in next PR with a simple search & replace: * before: `stdout, err := RunInDir(path)` * next: `stdout, _, err := RunWithContextString(&git.RunContext{Dir:path})` Other changes: 1. When `timeout <= 0`, use default. Because `timeout==0` is meaningless and could cause bugs. And now many functions becomes more simple, eg: `GitGcRepos` 9 lines to 1 line. `Fsck` 6 lines to 1 line. 2. Only set defaultCommandExecutionTimeout when the option `setting.Git.Timeout.Default > 0` |
2 years ago | |
---|---|---|
.. | ||
activitypub | 2 years ago | |
analyze | 3 years ago | |
appstate | 2 years ago | |
auth | 2 years ago | |
avatar | 2 years ago | |
base | 2 years ago | |
cache | 2 years ago | |
charset | 2 years ago | |
container | 2 years ago | |
context | 2 years ago | |
convert | 2 years ago | |
csv | 2 years ago | |
doctor | 2 years ago | |
emoji | 2 years ago | |
eventsource | 3 years ago | |
generate | 2 years ago | |
git | 2 years ago | |
gitgraph | 2 years ago | |
graceful | 2 years ago | |
hcaptcha | 4 years ago | |
highlight | 2 years ago | |
hostmatcher | 2 years ago | |
httpcache | 2 years ago | |
httplib | 2 years ago | |
indexer | 2 years ago | |
json | 2 years ago | |
lfs | 2 years ago | |
log | 2 years ago | |
markup | 2 years ago | |
metrics | 2 years ago | |
migration | 2 years ago | |
nosql | 2 years ago | |
notification | 2 years ago | |
options | 2 years ago | |
packages | 2 years ago | |
password | 3 years ago | |
pprof | 3 years ago | |
private | 2 years ago | |
process | 2 years ago | |
proxy | 3 years ago | |
public | 2 years ago | |
queue | 2 years ago | |
recaptcha | 3 years ago | |
references | 2 years ago | |
repository | 2 years ago | |
secret | 2 years ago | |
session | 2 years ago | |
setting | 2 years ago | |
ssh | 2 years ago | |
storage | 2 years ago | |
structs | 2 years ago | |
svg | 3 years ago | |
sync | 5 years ago | |
templates | 2 years ago | |
test | 2 years ago | |
timeutil | 2 years ago | |
translation | 2 years ago | |
typesniffer | 2 years ago | |
updatechecker | 2 years ago | |
upload | 3 years ago | |
uri | 3 years ago | |
user | 4 years ago | |
util | 2 years ago | |
validation | 2 years ago | |
web | 2 years ago |