meissa
/
forgejo
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'b942838bd4'
${ noResults }
forgejo/web_src/js/features
History
delvh 81fe5d6185
Convert `<div class="button">` to `<button class="button">` (#23337) 
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 		1 year ago
..
admin Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
comp Scoped labels: set aria-disabled on muted Exclusive option for a11y (#23306) 1 year ago
aria.js Fix incorrect display for comment context menu (#23343) 1 year ago
aria.md Improve frontend guidelines (#23007) 1 year ago
captcha.js Add new captcha: cloudflare turnstile (#22369) 1 year ago
citation.js Fix switched citation format (#23250) 1 year ago
clipboard.js Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
codeeditor.js Quick fixes monaco-editor error: "vs.editor.nullLanguage" (#21734) 2 years ago
colorpicker.js JS refactors (#22227) 2 years ago
common-global.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
common-issue.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
common-organization.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
contextpopup.js Change interactiveBorder to fix popup preview (#23169) 1 year ago
copycontent.js JS refactors (#22227) 2 years ago
dropzone.js JS refactors (#22227) 2 years ago
emoji.js JS refactors (#22227) 2 years ago
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2 years ago
file-fold.js JS refactors (#22227) 2 years ago
formatting.js JS refactors (#22227) 2 years ago
heatmap.js JS refactors (#22227) 2 years ago
imagediff.js Fix various ImageDiff/SVG bugs (#23312) 1 year ago
install.js Fix various bugs for "install" page (#23194) 1 year ago
notification.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
org-team.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
pull-view-file.js Replace unstyled meter with progress (#19968) 2 years ago
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2 years ago
repo-code.js Fix links for the menus in the view file page (#22795) 1 year ago
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) 2 years ago
repo-commit.js Fix hidden commit status on multiple checks (#22889) 1 year ago
repo-common.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-diff-filetree.js JS refactors (#22227) 2 years ago
repo-diff.js Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 1 year ago
repo-editor.js Support paste treepath when creating a new file or updating the file name (#23209) 1 year ago
repo-findfile.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-findfile.test.js Escape path for the file list (#22741) 1 year ago
repo-graph.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-home.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-issue-content.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-issue-pr-form.js JS refactors (#22227) 2 years ago
repo-issue.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
repo-legacy.js Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
repo-migrate.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-migration.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-projects.js Sync the class change of Edit Column Button to JS code (#23400) 1 year ago
repo-release.js Hide target selector if tag exists when creating new release (#23171) 1 year ago
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2 years ago
repo-template.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-unicode-escape.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2 years ago
serviceworker.js JS refactors (#22227) 2 years ago
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 3 years ago
stopwatch.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
tablesort.js JS refactors (#22227) 2 years ago
tribute.js JS refactors (#22227) 2 years ago
user-auth-webauthn.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-auth.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-settings.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago