You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/services
Zettat123 9a83aa28a3
Get rules by id when editing branch protection rule (#22932)
When users rename an existing branch protection rule, a new rule with
the new name will be created and the old rule will still exist.

![image](https://user-images.githubusercontent.com/15528715/219276442-d3c001ad-e693-44ec-9ad2-b33f2666b49b.png)

---

![image](https://user-images.githubusercontent.com/15528715/219276478-547c3b93-b3f1-4292-a1ef-c1b7747fe1bb.png)

The reason is that the `SettingsProtectedBranchPost` function only get
branch protection rule by name before updating or creating a rule. When
the rule name changes, the function cannot find the existing rule so it
will create a new rule rather than update the existing rule. To fix the
bug, the function should get rule by id first.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
1 year ago
..
actions Add context cache as a request level cache (#22294) 1 year ago
agit Rename almost all Ctx functions (#22071) 1 year ago
asymkey Add context cache as a request level cache (#22294) 1 year ago
attachment Add API management for issue/pull and comment attachments (#21783) 1 year ago
auth Add context cache as a request level cache (#22294) 1 year ago
automerge Improve trace logging for pulls and processes (#22633) 1 year ago
context Support org/user level projects (#22235) 1 year ago
convert Rename `GetUnits` to `LoadUnits` (#22970) 1 year ago
cron Add Cargo package registry (#21888) 1 year ago
externalaccount Implement FSFE REUSE for golang files (#21840) 1 year ago
forms Get rules by id when editing branch protection rule (#22932) 1 year ago
gitdiff Refactor git command package to improve security and maintainability (#22678) 1 year ago
issue Webhooks: for issue close/reopen action, add commit ID that caused it (#22583) 1 year ago
lfs Use context parameter in models/git (#22367) 1 year ago
mailer fix permission check for creating comment while mail (#22524) 1 year ago
markup Implement FSFE REUSE for golang files (#21840) 1 year ago
migrations Scoped labels (#22585) 1 year ago
mirror Use proxy for pull mirror (#22771) 1 year ago
org Implement FSFE REUSE for golang files (#21840) 1 year ago
packages Use import of OCI structs (#22765) 1 year ago
pull Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 1 year ago
release Add context cache as a request level cache (#22294) 1 year ago
repository Scoped labels (#22585) 1 year ago
task Implement FSFE REUSE for golang files (#21840) 1 year ago
user Add context cache as a request level cache (#22294) 1 year ago
webhook Refactor the setting to make unit test easier (#22405) 1 year ago
wiki Improve utils of slices (#22379) 1 year ago