You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/modules
zeripath c9c5bd88be
Stop logging EOFs and exit(1)s in ssh handler (#20476)
The code in modules/ssh/ssh.go:sessionHandler() currently cause an error to be
logged if `gitea serv` exits with a exit(1). This logging is useless because the
accompanying stderr is not provided and in any case the exit(1) is most likely due
to permissions errors.

Further it then causes the EOF to be logged - even though this is not helpful.

This PR simply checks the errors returned and stops logging them.

In the case of misconfigurations causing `gitea serv` to fail with exit(1)
the current logging is not helpful at determining this and users should simply
review the message passed over the ssh connection.

Fix #20473

Signed-off-by: Andrew Thornton <art27@cantab.net>
2 years ago
..
activitypub Add more linters to improve code readability (#19989) 2 years ago
analyze Simplify `IsVendor` (#19626) 2 years ago
appstate Use a struct as test options (#19393) 2 years ago
auth Remove legacy `+build:` constraint (#19582) 2 years ago
avatar Remove legacy `+build:` constraint (#19582) 2 years ago
base Add more linters to improve code readability (#19989) 2 years ago
cache Update go-chi/cache to utilize Ping() (#19719) 2 years ago
charset Fix various typos (#20338) 2 years ago
container Move reaction to models/issues/ (#19264) 2 years ago
context Extended permission checks. (#20517) 2 years ago
convert Include login_name in adminCreateUser response (#20283) 2 years ago
csv Allow render HTML with css/js external links (#19017) 2 years ago
doctor Fix various typos (#20338) 2 years ago
emoji format with gofumpt (#18184) 2 years ago
eventsource Add more linters to improve code readability (#19989) 2 years ago
generate Use base32 for 2FA scratch token (#18384) 2 years ago
git Slightly simplify LastCommitCache (#20444) 2 years ago
gitgraph Add more linters to improve code readability (#19989) 2 years ago
graceful Add more linters to improve code readability (#19989) 2 years ago
hcaptcha hCaptcha Support (#12594) 4 years ago
highlight Improve code diff highlight, fix incorrect rendered diff result (#19958) 2 years ago
hostmatcher Add tests for the host checking logic, clarify the behaviors (#20328) 2 years ago
httpcache Add Cache-Control header to html and api responses, add no-transform (#20432) 2 years ago
httplib refactor httplib (#18338) 2 years ago
indexer Fix `dump-repo` git init, fix wrong error type for NullDownloader (#20182) 2 years ago
json Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 2 years ago
lfs Removed some vestigial code related to Range bounds checks (#20312) 2 years ago
log Empty log queue on flush and close (#19994) 2 years ago
markup Use body text color in repository files table links (#20386) 2 years ago
metrics format with gofumpt (#18184) 2 years ago
migration Fix `dump-repo` git init, fix wrong error type for NullDownloader (#20182) 2 years ago
mirror Implement sync push mirror on commit (#19411) 2 years ago
nosql Fix various typos (#20338) 2 years ago
notification Added email notification option to receive all own messages (#20179) 2 years ago
options Remove legacy `+build:` constraint (#19582) 2 years ago
packages Add Docker /v2/_catalog endpoint (#20469) 2 years ago
paginator Remove legacy unmaintained packages, refactor to support change default locale (#19308) 2 years ago
password Fixed assert statements. (#16089) 3 years ago
pprof refactor: move from io/ioutil to io and os package (#17109) 3 years ago
private Allow manager logging to set SQL (#20064) 2 years ago
process Add more linters to improve code readability (#19989) 2 years ago
proxy Return nil proxy function if proxy not enabled (#16742) 3 years ago
public Remove legacy `+build:` constraint (#19582) 2 years ago
queue Add more linters to improve code readability (#19989) 2 years ago
recaptcha refactor: move from io/ioutil to io and os package (#17109) 3 years ago
references Add more linters to improve code readability (#19989) 2 years ago
regexplru Custom regexp external issues (#17624) 2 years ago
repository Adjust transaction handling via db.Context (#20031) 2 years ago
secret Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439) 2 years ago
session format with gofumpt (#18184) 2 years ago
setting Use default values when provided values are empty (#20318) 2 years ago
sitemap Add sitemap support (#18407) 2 years ago
ssh Stop logging EOFs and exit(1)s in ssh handler (#20476) 2 years ago
storage Add more linters to improve code readability (#19989) 2 years ago
structs Dismiss prior pull reviews if done via web in review dismiss (#20197) 2 years ago
svg Remove legacy `+build:` constraint (#19582) 2 years ago
sync Use queue instead of memory queue in webhook send service (#19390) 2 years ago
templates Vertical align avatar at middle (#20302) 2 years ago
test Move access and repo permission to models/perm/access (#19350) 2 years ago
timeutil Make better use of i18n (#20096) 2 years ago
translation Allow dev i18n to be more concurrent (#20159) 2 years ago
typesniffer Fix raw endpoint PDF file headers (#19825) 2 years ago
updatechecker format with gofumpt (#18184) 2 years ago
upload Simplify parameter types (#18006) 3 years ago
uri Prevent NPE if gitea uploader fails to open url (#18080) 3 years ago
user Add gitea-vet (#10948) 4 years ago
util Add more linters to improve code readability (#19989) 2 years ago
validation use IsLoopback (#19477) 2 years ago
web Fix various typos (#20338) 2 years ago