forgejo/routers/api/packages
Lunny Xiao ca67c5a8a7
refactor auth interface to return error when verify failure (#22119)
This PR changed the Auth interface signature from 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) *user_model.User`
to 
`Verify(http *http.Request, w http.ResponseWriter, store DataStore, sess
SessionStore) (*user_model.User, error)`.

There is a new return argument `error` which means the verification
condition matched but verify process failed, we should stop the auth
process.

Before this PR, when return a `nil` user, we don't know the reason why
it returned `nil`. If the match condition is not satisfied or it
verified failure? For these two different results, we should have
different handler. If the match condition is not satisfied, we should
try next auth method and if there is no more auth method, it's an
anonymous user. If the condition matched but verify failed, the auth
process should be stop and return immediately.

This will fix #20563

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: Jason Song <i@wolfogre.com>
2022-12-28 13:53:28 +08:00
..
composer Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
conan refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
container refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
generic Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helm Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helper Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
maven Replace fmt.Sprintf with hex.EncodeToString (#21960) 2022-11-28 11:19:18 +00:00
npm Fix condition for is_internal (#22095) 2022-12-14 17:16:01 +08:00
nuget refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00
pub Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
pypi Update go dev dependencies (#22064) 2022-12-08 16:21:37 +08:00
rubygems Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
vagrant Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
api.go refactor auth interface to return error when verify failure (#22119) 2022-12-28 13:53:28 +08:00