You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/modules/convert
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
convert.go Record OAuth client type at registration (#21316) 2 years ago
git_commit.go Add `stat` to `ToCommit` function for speed (#21337) 2 years ago
git_commit_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
issue.go Add more linters to improve code readability (#19989) 2 years ago
issue_comment.go Fix 500 on time tracking in timeline API (#21052) 2 years ago
issue_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
main_test.go Use a struct as test options (#19393) 2 years ago
mirror.go Add new API endpoints for push mirrors management (#19841) 2 years ago
notification.go Move some files into models' sub packages (#20262) 2 years ago
package.go Move access and repo permission to models/perm/access (#19350) 2 years ago
pull.go Move issues related files into models/issues (#19931) 2 years ago
pull_review.go Move issues related files into models/issues (#19931) 2 years ago
pull_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
release.go Move some files into models' sub packages (#20262) 2 years ago
repository.go Make external issue tracker regexp configurable via API (#21338) 2 years ago
status.go Move some code into models/git (#19879) 2 years ago
user.go Include login_name in adminCreateUser response (#20283) 2 years ago
user_test.go Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
utils.go Add migration from GitBucket (#16767) 3 years ago
utils_test.go A better go code formatter, and now `make fmt` can run in Windows (#17684) 3 years ago
wiki.go Move repository model into models/repo (#17933) 3 years ago