You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
admin.go Add Visible modes function from Organisation to Users too (#16069) 3 years ago
auth_form.go Rework mailer settings (#18982) 2 years ago
org.go Team permission allow different unit has different permission (#17811) 3 years ago
repo_branch_form.go Keep path when creating a new branch (#21153) 2 years ago
repo_form.go Limit length of repo description and repo url input fields (#21119) 2 years ago
repo_form_test.go format with gofumpt (#18184) 2 years ago
repo_tag_form.go Add tag protection (#15629) 3 years ago
user_form.go Record OAuth client type at registration (#21316) 2 years ago
user_form_auth_openid.go Add support mCaptcha as captcha provider (#20458) 2 years ago
user_form_hidden_comments.go Move issues related files into models/issues (#19931) 2 years ago
user_form_test.go Move modules/forms to services/forms (#15305) 3 years ago