You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/cmd
mrsdizzie ca46385637 Clean up various use of escape/unescape functions for URL generation (#6334)
* Use PathUnescape instead of QueryUnescape when working with branch names

Currently branch names with a '+' fail in certain situations because
QueryUnescape replaces the + character with a blank space.

Using PathUnescape should be better since it is defined as:

// PathUnescape is identical to QueryUnescape except that it does not
// unescape '+' to ' ' (space).

Fixes #6333

* Change error to match new function name

* Add new util function PathEscapeSegments

This function simply runs PathEscape on each segment of a path without
touching the forward slash itself. We want to use this instead of
PathEscape/QueryEscape in most cases because a forward slash is a valid name for a
branch etc... and we don't want that escaped in a URL.

Putting this in new file url.go and also moving a couple similar
functions into that file as well.

* Use EscapePathSegments where appropriate

Replace various uses of EscapePath/EscapeQuery with new
EscapePathSegments. Also remove uncessary uses of various
escape/unescape functions when the text had already been escaped or was
not escaped.

* Reformat comment to make drone build happy

* Remove no longer used url library

* Requested code changes
5 years ago
..
admin.go Allow for user specific themes (#5668) 6 years ago
cert.go General refactor of the cmd package (#3328) 7 years ago
cmd.go Disallow empty titles (#5785) 6 years ago
dump.go Add flag to skip repository dumping (#5695) 6 years ago
generate.go Integrate OAuth2 Provider (#5378) 5 years ago
hook.go Clean up various use of escape/unescape functions for URL generation (#6334) 5 years ago
keys.go Create AuthorizedKeysCommand (#5236) 6 years ago
migrate.go Add command for migrating database (#4954) 6 years ago
serv.go Fix ssh deploy and user key constraints (#1357) (#5939) 5 years ago
web.go Remove a double slash in the HTTPS redirection when Let's Encrypt is enabled (#5537) 6 years ago
web_graceful.go refactor: show command help message. (#1486) 7 years ago
web_windows.go fix windows build broken by #416 8 years ago