You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/models
zeripath d1e67d7ade
Fix bug preventing transfer to private organization (#12497)
* Fix bug preventing transfer to private organization

The code assessing whether a private organization was visible to a user before
allowing transfer was incorrect due to testing membership the wrong way round

This PR fixes this issue and renames the function performing the test to be
clearer.

Further looking at the API for transfer repository - no testing was
performed to ensure that the acting user could actually see the new
owning organization.

Signed-off-by: Andrew Thornton <art27@cantab.net>

* change IsUserPartOfOrg everywhere
4 years ago
..
fixtures API: Add pull review endpoints (#11224) 4 years ago
migrations Fix bug preventing transfer to private organization (#12497) 4 years ago
access.go Upgrade xorm to v1.0.0 (#10646) 4 years ago
access_test.go Fix "access" fixtures and tests (#10247) 4 years ago
action.go Make dashboard newsfeed list length a configurable item (#12469) 4 years ago
action_list.go refactor: reduce sql query in retrieveFeeds (#3547) 6 years ago
action_test.go Add gitea-vet (#10948) 4 years ago
admin.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
admin_test.go Fix tests code to prevent some runtime errors (#2381) 7 years ago
attachment.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
attachment_test.go Reading pull attachments should depend on read UnitTypePullRequests (#10346) 4 years ago
avatar.go make avatar lookup occur at image request (#10540) 4 years ago
branches.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
branches_test.go Add deleted_branch table fixture (#2832) 7 years ago
commit_status.go API add/generalize pagination (#9452) 4 years ago
commit_status_test.go Fix wrong hint when status checking is running on pull request view (#9886) 5 years ago
consistency.go Add migration to set IsArchived false if it is null (#11853) 4 years ago
context.go Upgrade xorm to v1.0.2 (#11900) 4 years ago
convert.go Move database settings from models to setting (#7806) 5 years ago
error.go Add API Endpoint for Branch Creation (#11607) 4 years ago
error_oauth2.go gofmt (#1662) 7 years ago
external_login_user.go Migrate reviews when migrating repository from github (#9463) 4 years ago
fixture_generation.go Move fixture generation to contrib and add test (#10277) 4 years ago
fixture_test.go Move fixture generation to contrib and add test (#10277) 4 years ago
gpg_key.go Keys should not verify revoked email addresses (#12486) 4 years ago
gpg_key_test.go Display ui time with customize time location (#7792) 5 years ago
helper.go Add reactions to issues/PR and comments (#2856) 7 years ago
helper_directory.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
helper_environment.go Move PushUpdateAddDeleteTags to repository module from models (#10106) 4 years ago
issue.go Increase maximum SQLite variables count to 32766 (#11696) 4 years ago
issue_assignees.go Remove Unused Functions (#10516) 4 years ago
issue_assignees_test.go Fix API Bug (fail on empty assignees) (#8873) 5 years ago
issue_comment.go fix bug about can't skip commits base on base branch (#11555) 4 years ago
issue_comment_list.go Fixed repo link in generated comment for cross repository dependency (#9863) 5 years ago
issue_comment_test.go Pull request review/approval and comment on code (#3748) 6 years ago
issue_dependency.go Display ui time with customize time location (#7792) 5 years ago
issue_dependency_test.go Refactor comment (#9330) 5 years ago
issue_label.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
issue_label_test.go BugFix: updateLabel can updated not allowed fields #11242 (#11242) 4 years ago
issue_list.go [BugFix] ReviewCount: GetApprovalCounts func sorted wrong (#11086) 4 years ago
issue_list_test.go Add Organization Wide Labels (#10814) 4 years ago
issue_lock.go remove unused method and rename createcommentWithNoAction (#9367) 5 years ago
issue_milestone.go Add name filter to API for GetMilestoneList (#12336) 4 years ago
issue_milestone_test.go Add name filter to API for GetMilestoneList (#12336) 4 years ago
issue_reaction.go API add/generalize pagination (#9452) 4 years ago
issue_reaction_test.go Migrate reactions when migrating repository from github (#9599) 5 years ago
issue_stopwatch.go When starting new stopwatch stop previous if it is still running (#10533) 4 years ago
issue_stopwatch_test.go Add gitea-vet (#10948) 4 years ago
issue_test.go issue search on my related repositories (#9758) 4 years ago
issue_tracked_time.go Fix tracked time issues (#11349) 4 years ago
issue_tracked_time_test.go [API] Extend times API (#9200) 5 years ago
issue_user.go Mail assignee when issue/pull request is assigned (#8546) 5 years ago
issue_user_test.go Add "Update Branch" button to Pull Requests (#9784) 5 years ago
issue_watch.go Add issue subscription check to API (#10967) 4 years ago
issue_watch_test.go API add/generalize pagination (#9452) 4 years ago
issue_xref.go remove unused method and rename createcommentWithNoAction (#9367) 5 years ago
issue_xref_test.go Refactor comment (#9330) 5 years ago
lfs.go Add gitea-vet (#10948) 4 years ago
lfs_lock.go Make repository management section handle lfs locks (#8726) 5 years ago
list_options.go Use DEFAULT_PAGING_NUM instead of MAX_RESPONSE_ITEMS in ListOptions (#11831) 4 years ago
log.go Upgrade xorm to v1.0.0 (#10646) 4 years ago
login_source.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
main_test.go Add gitea-vet (#10948) 4 years ago
migrate.go [BugFix] remove nil inserts in models (#11096) 4 years ago
models.go Support use nvarchar for all varchar columns when using mssql (#12269) 4 years ago
models_test.go Move database settings from models to setting (#7806) 5 years ago
notification.go Extend Notifications API and return pinned notifications by default (#12164) 4 years ago
notification_test.go add request review from specific reviewers feature in pull request (#10756) 4 years ago
oauth2.go Changed image of openid-connect logo for better look on arc-green theme (#11312) 4 years ago
oauth2_application.go Use google/uuid to instead satori/go.uuid (#11943) 4 years ago
oauth2_application_test.go OAuth2 Grant UI (#6625) 5 years ago
org.go Fix bug preventing transfer to private organization (#12497) 4 years ago
org_team.go Automatically remove Watches, Assignments, etc if user loses access due to being removed as collaborator or from a team (#10997) 4 years ago
org_team_test.go API add/generalize pagination (#9452) 4 years ago
org_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa (#10134) 4 years ago
pull.go Cache PullRequest Divergence (#10914) 4 years ago
pull_list.go API add/generalize pagination (#9452) 4 years ago
pull_sign.go models: break out of loop (#12386) 4 years ago
pull_test.go Display pull request head branch even the branch deleted or repository deleted (#10413) 4 years ago
release.go Add single release page and latest redirect (#11102) 4 years ago
repo.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
repo_activity.go Add top author stats to activity page (#9615) 5 years ago
repo_branch.go Move newbranch to standalone package (#9627) 5 years ago
repo_collaboration.go Automatically remove Watches, Assignments, etc if user loses access due to being removed as collaborator or from a team (#10997) 4 years ago
repo_collaboration_test.go API add/generalize pagination (#9452) 4 years ago
repo_generate.go API add/generalize pagination (#9452) 4 years ago
repo_generate_test.go Variable expansion in repository templates (#9163) 5 years ago
repo_indexer.go Index code and stats only for non-empty repositories (#10251) 4 years ago
repo_issue.go Add EnableTimetracking option to app settings (#3719) 6 years ago
repo_language_stats.go Increase size of the language column in language_stat (#12396) 4 years ago
repo_list.go Fix repo-list private and total count bugs (#11500) 4 years ago
repo_list_test.go API add/generalize pagination (#9452) 4 years ago
repo_mirror.go Move some repository methods from models to modules/repository (#9353) 5 years ago
repo_permission.go Automatically remove Watches, Assignments, etc if user loses access due to being removed as collaborator or from a team (#10997) 4 years ago
repo_permission_test.go fix bug when update owner team then visit team's repo return 404 (#6119) 5 years ago
repo_redirect.go Move repoWorkPool outside rename/transfer repository (#9086) 5 years ago
repo_redirect_test.go Move repoWorkPool outside rename/transfer repository (#9086) 5 years ago
repo_sign.go models: break out of loops (#12159) 4 years ago
repo_test.go Decrease the num_stars when deleting a repo (#11954) 4 years ago
repo_unit.go Upgrade xorm to v1.0.0 (#10646) 4 years ago
repo_watch.go Add action feed for new release (#12324) 4 years ago
repo_watch_test.go API add/generalize pagination (#9452) 4 years ago
review.go Update Octicons to v10 (#12240) 4 years ago
review_test.go Update Octicons to v10 (#12240) 4 years ago
ssh_key.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
ssh_key_test.go Fix SSH2 conditonal in key parsing code (#8806) 5 years ago
star.go API add/generalize pagination (#9452) 4 years ago
star_test.go API add/generalize pagination (#9452) 4 years ago
task.go Move create/fork repository from models to modules/repository (#9489) 5 years ago
test_fixtures.go upgrade to use testfixtures v3 (#11904) 4 years ago
token.go Use google/uuid to instead satori/go.uuid (#11943) 4 years ago
token_test.go Reject duplicate AccessToken names (#10994) 4 years ago
topic.go Update topics repo count when deleting repository (#10051) 4 years ago
topic_test.go API add/generalize pagination (#9452) 4 years ago
twofactor.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
u2f.go Display ui time with customize time location (#7792) 5 years ago
u2f_test.go Add gitea-vet (#10948) 4 years ago
unit.go Add setting to set default and global disabled repository units. (#8788) 5 years ago
unit_tests.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
update.go Remove Unused Functions (#10516) 4 years ago
upload.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
user.go Fix bug preventing transfer to private organization (#12497) 4 years ago
user_follow.go Refactor session close as xorm already does everything needed internally (#2020) 7 years ago
user_follow_test.go Add gitea-vet (#10948) 4 years ago
user_heatmap.go Add hide activity option (#11353) 4 years ago
user_heatmap_test.go Restricted users (#6274) 5 years ago
user_mail.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
user_mail_test.go Admin page for managing user e-mail activation (#10557) 4 years ago
user_openid.go Use ID or Where to instead directly use Get when load object from database (#11925) 4 years ago
user_openid_test.go Add golangci (#6418) 5 years ago
user_test.go Ensure DeleteUser is not allowed to Delete Orgs and visa versa (#10134) 4 years ago
userlist.go API add/generalize pagination (#9452) 4 years ago
userlist_test.go Team permission to create repository in organization (#8312) 5 years ago
webhook.go Use google/uuid to instead satori/go.uuid (#11943) 4 years ago
webhook_test.go Granular webhook events (#9626) 4 years ago
wiki.go Add owner_name column for table repository for maintaince reason (#9717) 5 years ago
wiki_test.go Move wiki related funtions from models to services/wiki (#9355) 5 years ago