meissa
/
forgejo
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'd67e40684f'
${ noResults }
forgejo/web_src/js/features
History
Hester Gong ca905b82df
Append `(comment)` when a link points at a comment rather than the whole issue (#23734) 
Close #23671 

For the feature mentioned above, this PR append ' (comment)' to the
rendered html if it is a hashcomment.
After the PR, type in the following

```
pull request from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2

pull request from this repo:
http://localhost:3000/aaa/testA/pulls/2

issue comment from this repo:
http://localhost:3000/aaa/testA/issues/1#issuecomment-18

http://localhost:3000/aaa/testA/pulls/2#issue-9

issue comment from other repo:
http://localhost:3000/testOrg/testOrgRepo/pulls/2#issuecomment-24

http://localhost:3000/testOrg/testOrgRepo/pulls/2#issue
```
Gives:
<img width="687" alt="截屏2023-03-27 13 53 06"
src="https://user-images.githubusercontent.com/17645053/227852387-2b218e0d-3468-4d90-ad81-d702ddd17fd2.png">



Other than the above feature, this PR also includes two other changes:

1 Right now, the render of links from file changed tab in pull request
might not be very proper, for example, if type in the following. (not
sure if this is an issue or design, if not an issue, I will revert the
changes). example on
[try.gitea.io](https://try.gitea.io/HesterG/testrepo/pulls/1)
```
https://try.gitea.io/HesterG/testrepo/pulls/1/files#issuecomment-162725
https://try.gitea.io/HesterG/testrepo/pulls/1/files
```
it will render the following 
<img width="899" alt="截屏2023-03-24 15 41 37"
src="https://user-images.githubusercontent.com/17645053/227456117-5eccedb7-9118-4540-929d-aee9a76de852.png">

In this PR, skip processing the link into a ref issue if it is a link
from files changed tab in pull request

After:
type in following
```
hash comment on files changed tab:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files#issuecomment-24

files changed link:
http://localhost:3000/testOrg/testOrgRepo/pulls/2/files
```
Gives

<img width="708" alt="截屏2023-03-27 22 09 02"
src="https://user-images.githubusercontent.com/17645053/227964273-5dc06c50-3713-489c-b05d-d95367d0ab0f.png">

2 Right now, after editing the comment area, there will not be tippys
attached to `ref-issue`; and no tippy attached on preview as well.
example:

https://user-images.githubusercontent.com/17645053/227850540-5ae34e2d-b1d7-4d0d-9726-7701bf825d1f.mov

In this PR, in frontend, make sure tippy is added after editing the
comment, and to the comment on preview tab
After:

https://user-images.githubusercontent.com/17645053/227853777-06f56b4c-1148-467c-b6f7-f79418e67504.mov
 		1 year ago
..
admin Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
comp Append `(comment)` when a link points at a comment rather than the whole issue (#23734) 1 year ago
captcha.js Add new captcha: cloudflare turnstile (#22369) 1 year ago
citation.js Fix switched citation format (#23250) 1 year ago
clipboard.js Use clippie module to copy to clipboard (#23801) 1 year ago
codeeditor.js Allow new file and edit file preview if it has editable extension (#23624) 1 year ago
colorpicker.js JS refactors (#22227) 2 years ago
common-global.js Fix dropdown direction behavior (#23806) 1 year ago
common-issue.js Convert issue list checkboxes to native (#23596) 1 year ago
common-organization.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
contextpopup.js Append `(comment)` when a link points at a comment rather than the whole issue (#23734) 1 year ago
copycontent.js Use clippie module to copy to clipboard (#23801) 1 year ago
dropzone.js JS refactors (#22227) 2 years ago
emoji.js JS refactors (#22227) 2 years ago
eventsource.sharedworker.js Fix the JS error "EventSource is not defined" caused by some non-standard browsers (#20584) 2 years ago
file-fold.js JS refactors (#22227) 2 years ago
formatting.js JS refactors (#22227) 2 years ago
heatmap.js JS refactors (#22227) 2 years ago
imagediff.js Fix various ImageDiff/SVG bugs (#23312) 1 year ago
install.js Fix various bugs for "install" page (#23194) 1 year ago
notification.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
org-team.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
pull-view-file.js Replace unstyled meter with progress (#19968) 2 years ago
repo-branch.js Add apply-patch, basic revert and cherry-pick functionality (#17902) 2 years ago
repo-code.js Use clippie module to copy to clipboard (#23801) 1 year ago
repo-code.test.js Ignore line anchor links with leading zeroes (#21728) 2 years ago
repo-commit.js Fix hidden commit status on multiple checks (#22889) 1 year ago
repo-common.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-diff-filetree.js JS refactors (#22227) 2 years ago
repo-diff.js Use a general approach to show tooltip, fix temporary tooltip bug (#23574) 1 year ago
repo-editor.js Editor preview support for external renderers (#23333) 1 year ago
repo-findfile.js Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
repo-findfile.test.js Refactor branch/tag selector to Vue SFC (#23421) 1 year ago
repo-graph.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-home.js Fine tune more downdrop settings, use SVG for labels, improve Repo Topic Edit form (#23626) 1 year ago
repo-issue-content.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-issue-pr-form.js JS refactors (#22227) 2 years ago
repo-issue.js Fix JS error when changing PR's target branch (#23862) 1 year ago
repo-legacy.js Append `(comment)` when a link points at a comment rather than the whole issue (#23734) 1 year ago
repo-migrate.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-migration.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-projects.js Sync the class change of Edit Column Button to JS code (#23400) 1 year ago
repo-release.js Hide target selector if tag exists when creating new release (#23171) 1 year ago
repo-settings.js Remove customized (unmaintained) dropdown, improve aria a11y for dropdown (#19861) 2 years ago
repo-template.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-unicode-escape.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
repo-wiki.js Enable spellcheck for EasyMDE, use contenteditable mode (#19776) 2 years ago
serviceworker.js JS refactors (#22227) 2 years ago
sshkey-helper.js Use explicit jQuery import, remove unused eslint globals (#18435) 3 years ago
stopwatch.js Move helpers to be prefixed with `gt-` (#22879) 1 year ago
tablesort.js JS refactors (#22227) 2 years ago
tribute.js JS refactors (#22227) 2 years ago
user-auth-webauthn.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-auth.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
user-settings.js Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago