You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 6e22605793
Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017)
As recognised in #21841 the rendering of plain text files is somewhat
incorrect when there are ambiguous characters as the html code is double
escaped. In fact there are several more problems here.

We have a residual isRenderedHTML which is actually simply escaping the
file - not rendering it. This is badly named and gives the wrong
impression.

There is also unusual behaviour whether the file is called a Readme or
not and there is no way to get to the source code if the file is called
README.

In reality what should happen is different depending on whether the file
is being rendered a README at the bottom of the directory view or not.

1. If it is rendered as a README on a directory - it should simply be
escaped and rendered as `<pre>` text.
2. If it is rendered as a file then it should be rendered as source
code.

This PR therefore does:
1. Rename IsRenderedHTML to IsPlainText
2. Readme files rendered at the bottom of the directory are rendered
without line numbers
3. Otherwise plain text files are rendered as source code.

Replace #21841

Signed-off-by: Andrew Thornton <art27@cantab.net>

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2 years ago
..
branch Fix button in branch list, avoid unexpected page jump before restore branch actually done (#21562) 2 years ago
cite Copy citation file content, in APA and BibTex format, on repo home page (#19999) 2 years ago
diff Change ID pattern of raw content container for issue (#21966) 2 years ago
editor Rename almost all Ctx functions (#22071) 2 years ago
find Refactor `i18n` to `locale` (#20153) 2 years ago
graph Rename almost all Ctx functions (#22071) 2 years ago
issue Rename almost all Ctx functions (#22071) 2 years ago
migrate Remove useless "Cancel" buttons (#21872) 2 years ago
projects Optimize html templates (#22080) 2 years ago
pulls Remove useless "Cancel" buttons (#21872) 2 years ago
release Optimize html templates (#22080) 2 years ago
settings Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) 2 years ago
wiki Webhook for Wiki changes (#20219) 2 years ago
activity.tmpl Respect user's locale when rendering the date range in the repo activity page (#21410) 2 years ago
blame.tmpl Show syntax lexer name in file view/blame (#21814) 2 years ago
branch_dropdown.tmpl Fix branch dropdown shifting on page load (#21428) 2 years ago
clone_buttons.tmpl Rework repo buttons (#20602) 2 years ago
clone_script.tmpl Make the vscode clone link respect transport protocol (#20557) 2 years ago
commit_page.tmpl Rename actions to operations on UI (#22067) 2 years ago
commit_status.tmpl Change commit status icons to SVG (#20736) 2 years ago
commit_statuses.tmpl Improve commit status icons (#21124) 2 years ago
commits.tmpl Rework repo buttons (#20602) 2 years ago
commits_list.tmpl Change `commits-table` column width (#21564) 2 years ago
commits_list_small.tmpl Add whitespace removal inside template curly brackes (#20853) 2 years ago
commits_table.tmpl Add whitespace removal inside template curly brackes (#20853) 2 years ago
create.tmpl Remove cancel button in repo creation page (#21381) 2 years ago
empty.tmpl Add default value for clone URLs (#20600) 2 years ago
file_info.tmpl Show syntax lexer name in file view/blame (#21814) 2 years ago
forks.tmpl Add whitespace removal inside template curly brackes (#20853) 2 years ago
graph.tmpl Add whitespace removal inside template curly brackes (#20853) 2 years ago
header.tmpl Rename almost all Ctx functions (#22071) 2 years ago
home.tmpl Rename actions to operations on UI (#22067) 2 years ago
icon.tmpl Do not display org avatar near icon for internal repos (#13957) 4 years ago
packages.tmpl Add Package Registry (#16510) 2 years ago
search.tmpl Add user/organization code search (#19977) 2 years ago
shabox_badge.tmpl Refactor `i18n` to `locale` (#20153) 2 years ago
sub_menu.tmpl Render number of commits in repo page in a user friendly way (#21786) 2 years ago
unicode_escape_prompt.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2 years ago
upload.tmpl Refactor `i18n` to `locale` (#20153) 2 years ago
user_cards.tmpl Localize all timestamps (#21440) 2 years ago
view_file.tmpl Ensure that plain files are rendered correctly even when containing ambiguous characters (#22017) 2 years ago
view_list.tmpl Add whitespace removal inside template curly brackes (#20853) 2 years ago
watchers.tmpl Add class to page content to unify top margin (#13766) 4 years ago