meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e4addac26e'
${ noResults }
forgejo/services
History
Peter Gardfjäll 4562d40fce
fix hard-coded timeout and error panic in API archive download endpoint (#20925) 
* fix hard-coded timeout and error panic in API archive download endpoint

This commit updates the `GET /api/v1/repos/{owner}/{repo}/archive/{archive}`
endpoint which prior to this PR had a couple of issues.

1. The endpoint had a hard-coded 20s timeout for the archiver to complete after
   which a 500 (Internal Server Error) was returned to client. For a scripted
   API client there was no clear way of telling that the operation timed out and
   that it should retry.

2. Whenever the timeout _did occur_, the code used to panic. This was caused by
   the API endpoint "delegating" to the same call path as the web, which uses a
   slightly different way of reporting errors (HTML rather than JSON for
   example).

   More specifically, `api/v1/repo/file.go#GetArchive` just called through to
   `web/repo/repo.go#Download`, which expects the `Context` to have a `Render`
   field set, but which is `nil` for API calls. Hence, a `nil` pointer error.

The code addresses (1) by dropping the hard-coded timeout. Instead, any
timeout/cancelation on the incoming `Context` is used.

The code addresses (2) by updating the API endpoint to use a separate call path
for the API-triggered archive download. This avoids producing HTML-errors on
errors (it now produces JSON errors).

Signed-off-by: Peter Gardfjäll <peter.gardfjall.work@gmail.com>
 		2 years ago
..
agit Add more linters to improve code readability (#19989) 2 years ago
asymkey Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
attachment Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
auth Share HTML template renderers and create a watcher framework (#20218) 2 years ago
automerge Add more linters to improve code readability (#19989) 2 years ago
comments Move issues related files into models/issues (#19931) 2 years ago
context Move almost all functions' parameter db.Engine to context.Context (#19748) 2 years ago
cron Move some files into models' sub packages (#20262) 2 years ago
externalaccount Refactor auth package (#17962) 3 years ago
forms refactor webhook *NewPost (#20729) 2 years ago
gitdiff Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
issue Move some files into models' sub packages (#20262) 2 years ago
lfs Move some code into models/git (#19879) 2 years ago
mailer Share HTML template renderers and create a watcher framework (#20218) 2 years ago
migrations Move some files into models' sub packages (#20262) 2 years ago
mirror Add new API endpoints for push mirrors management (#19841) 2 years ago
org Move some files into models' sub packages (#20262) 2 years ago
packages Replace `ServeStream` with `ServeContent` (#20903) 2 years ago
pull Prevent 500 is head repo does not have PullRequest unit in IsUserAllowedToUpdate (#20839) 2 years ago
release Move some files into models' sub packages (#20262) 2 years ago
repository fix hard-coded timeout and error panic in API archive download endpoint (#20925) 2 years ago
task Move some files into models' sub packages (#20262) 2 years ago
user Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
webhook Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
wiki Move some files into models' sub packages (#20262) 2 years ago