You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/services
Jason Song 1960ad5c90
Improve cache context (#23330)
Related to: #22294 #23186 #23054

Replace: #23218

Some discussion is in the comments of #23218.

Highlights:
- Add Expiration for cache context. If a cache context has been used for
more than 10s, the cache data will be ignored, and warning logs will be
printed.
- Add `discard` field to `cacheContext`, a `cacheContext` with `discard`
true will drop all cached data and won't store any new one.
- Introduce `WithNoCacheContext`, if one wants to run long-life tasks,
but the parent context is a cache context,
`WithNoCacheContext(perentCtx)` will discard the cache data, so it will
be safe to keep the context for a long time.
- It will be fine to treat an original context as a cache context, like
`GetContextData(context.Backgraud())`, no warning logs will be printed.

Some cases about nesting:

When:
- *A*, *B* or *C* means a cache context.
- ~*A*~, ~*B*~ or ~*C*~ means a discard cache context.
- `ctx` means `context.Backgrand()`
- *A(ctx)* means a cache context with `ctx` as the parent context.
- *B(A(ctx))* means a cache context with `A(ctx)` as the parent context.
- `With` means `WithCacheContext`
- `WithNo` means `WithNoCacheContext`

So:
- `With(ctx)` -> *A(ctx)*
- `With(With(ctx))` -> *A(ctx)*, not *B(A(ctx))*
- `With(With(With(ctx)))` -> *A(ctx)*, not *C(B(A(ctx)))*
- `WithNo(ctx)` -> *ctx*, not *~A~(ctx)*
- `WithNo(With(ctx))` -> *~A~(ctx)*
- `WithNo(WithNo(With(ctx)))` -> *~A~(ctx)*, not *~B~(~A~(ctx))*
- `With(WithNo(With(ctx)))` -> *B(~A~(ctx))*
- `WithNo(With(WithNo(With(ctx))))` -> *~B~(~A~(ctx))*
- `With(WithNo(With(WithNo(With(ctx)))))` -> *C(~B~(~A~(ctx)))*
1 year ago
..
actions Avoid panic caused by broken payload when creating commit status (#23216) 1 year ago
agit Rename almost all Ctx functions (#22071) 2 years ago
asymkey Add context cache as a request level cache (#22294) 1 year ago
attachment Add API management for issue/pull and comment attachments (#21783) 2 years ago
auth Use minio/sha256-simd for accelerated SHA256 (#23052) 1 year ago
automerge Add force_merge to merge request and fix checking mergable (#23010) 1 year ago
context Support org/user level projects (#22235) 1 year ago
convert Fix SyncOnCommit always return false in API of push_mirrors (#23088) 1 year ago
cron Add Cargo package registry (#21888) 1 year ago
externalaccount Implement FSFE REUSE for golang files (#21840) 2 years ago
forms Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 1 year ago
gitdiff Fix broken code editor diff preview (#23307) 1 year ago
issue Webhooks: for issue close/reopen action, add commit ID that caused it (#22583) 1 year ago
lfs Use minio/sha256-simd for accelerated SHA256 (#23052) 1 year ago
mailer Make Ctrl+Enter submit a pending comment (starting review) instead of submitting a single comment (#23245) 1 year ago
markup Implement FSFE REUSE for golang files (#21840) 2 years ago
migrations Use CleanPath instead of path.Clean (#23371) 1 year ago
mirror Fill head commit to in payload when notifying push commits for mirroring (#23215) 1 year ago
org Implement FSFE REUSE for golang files (#21840) 2 years ago
packages Use CleanPath instead of path.Clean (#23371) 1 year ago
pull Refactor and tidy-up the merge/update branch code (#22568) 1 year ago
release Add context cache as a request level cache (#22294) 1 year ago
repository Improve cache context (#23330) 1 year ago
task Implement FSFE REUSE for golang files (#21840) 2 years ago
user Add context cache as a request level cache (#22294) 1 year ago
webhook Use minio/sha256-simd for accelerated SHA256 (#23052) 1 year ago
wiki Improve utils of slices (#22379) 2 years ago