meissa
/
forgejo
7
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'e9288c2477'
${ noResults }
forgejo/templates
History
wxiaoguang affdd40296
Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 
Replace #19922 , which is stale since my last review:
https://github.com/go-gitea/gitea/pull/19922#pullrequestreview-1003546506
and https://github.com/go-gitea/gitea/pull/19922#issuecomment-1153181546

Close #19769

Changes:
1. Use `<button>` instead of `<div>` for buttons
2. Prevent default event handler in `initGlobalButtonClickOnEnter`
3. Fix the incorrect call to `pullrequest_targetbranch_change`
4. Add a slight margin-left to the input element to make UI look better

The logic in repo-issue.js is not ideal, but this PR isn't going to
touch the logic.

This is also an example for future developers to understand how to make
buttons work properly.

### Before


![image](https://user-images.githubusercontent.com/2114189/217262515-ec0462f7-7051-46a5-bfa2-2f6c6a807b7d.png)

### After

* Add a slight margin-left.
* The `Cancel` button is focused.


![image](https://user-images.githubusercontent.com/2114189/217264891-934c9c8d-d190-4866-98b5-666cea57e28d.png)

Co-authored-by: techknowlogick <techknowlogick@gitea.io>
 		1 year ago
..
admin Map OIDC groups to Orgs/Teams (#21441) 1 year ago
api/packages/pypi Add Package Registry (#16510) 2 years ago
base Improve notification and stopwatch styles (#22169) 1 year ago
code Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
custom Add footer extra links template (#9576) 5 years ago
explore Add main landmark to templates and adjust titles (#22670) 1 year ago
mail Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
org Add Cargo package registry (#21888) 1 year ago
package Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
projects Fix more HTMLURL in templates (#22831) 1 year ago
repo Make issue title edit buttons focusable and fix incorrect ajax requests (#22807) 1 year ago
shared Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
status Add main landmark to templates and adjust titles (#22670) 1 year ago
swagger Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
user Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 1 year ago
home.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago
install.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago
post-install.tmpl Add main landmark to templates and adjust titles (#22670) 1 year ago