You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
1 year ago
..
chroma Add --font-weight-bold and set previous bold to 601 (#24307) 1 year ago
codemirror Replace Less with CSS (#23481) 1 year ago
editor Reorganize CSS files (#24739) 1 year ago
features Reorganize CSS files (#24739) 1 year ago
markup Add RTL rendering support to Markdown (#24816) 1 year ago
modules Fix OAuth loading state (#24788) 1 year ago
repo Reorganize CSS files (#24739) 1 year ago
shared Clean up various avatar dimensions (#24701) 1 year ago
standalone Replace Less with CSS (#23481) 1 year ago
themes Rework label colors (#24790) 1 year ago
actions.css Reorganize CSS files (#24739) 1 year ago
admin.css Fix config list overflow and layout (#24312) 1 year ago
base.css Add RTL rendering support to Markdown (#24816) 1 year ago
dashboard.css Remove highlight in repo list (#24675) 1 year ago
explore.css Improve "new-menu" (#24465) 1 year ago
font_i18n.css Replace Less with CSS (#23481) 1 year ago
form.css Rework Oauth login buttons, swap github logo to monocolor (#24740) 1 year ago
helpers.css Remove background on user dashboard filter bar (#24779) 1 year ago
home.css Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 1 year ago
index.css Reorganize CSS files (#24739) 1 year ago
install.css Add --font-weight-bold and set previous bold to 601 (#24307) 1 year ago
org.css Reorganize CSS files (#24739) 1 year ago
repo.css Improve accessibility when (re-)viewing files (#24817) 1 year ago
review.css Improve accessibility when (re-)viewing files (#24817) 1 year ago
user.css Improve button-ghost, remove tertiary button (#24692) 1 year ago