meissa
/
forgejo
6
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo-federated-star
forgejo
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ea1b92621b'
${ noResults }
forgejo/templates/repo/issue
History
delvh 81fe5d6185
Convert `<div class="button">` to `<button class="button">` (#23337) 
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 		1 year ago
..
fields Fix nil context in RenderMarkdownToHtml (#23092) 1 year ago
labels Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
view_content Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
branch_selector_field.tmpl Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
choose.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
comment_tab.tmpl Fix nil context in RenderMarkdownToHtml (#23092) 1 year ago
label_precolors.tmpl Fix purple color in suggested label colors (#18241) 3 years ago
labels.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
list.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
milestone_issues.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
milestone_new.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
milestones.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
navbar.tmpl Add some headings to repo views (#22869) 1 year ago
new.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
new_form.tmpl Deduplicate template code for label selection menu (#23431) 1 year ago
openclose.tmpl Move helpers to be prefixed with `gt-` (#22879) 1 year ago
search.tmpl Issues: add Project filter to issues list and search (#22544) 2 years ago
view.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
view_content.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
view_title.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago