You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/models/user
Gusted 623c93ff46
Increase Salt randomness (#18179)
- The current implementation of `RandomString` doesn't give you a most-possible unique randomness. It gives you 6*`length` instead of the possible 8*`length` bits(or as `length`x bytes) randomness. This is because `RandomString` is being limited to a max value of 63, this in order to represent the random byte as a letter/digit.
- The recommendation of pbkdf2 is to use 64+ bit salt, which the `RandomString` doesn't give with a length of 10, instead of increasing 10 to a higher number, this patch adds a new function called `RandomBytes` which does give you the guarentee of 8*`length` randomness and thus corresponding of `length`x bytes randomness.
- Use hexadecimal to store the bytes value in the database, as mentioned, it doesn't play nice in order to convert it to a string. This will always be a length of 32(with `length` being 16).
- When we detect on `Authenticate`(source: db) that a user has the old format of salt, re-hash the password such that the user will have it's password hashed with increased salt.

Thanks to @zeripath for working out the rouge edges from my first commit 😄.

Co-authored-by: lafriks <lauris@nix.lv>
Co-authored-by: zeripath <art27@cantab.net>
3 years ago
..
avatar.go Move user related model into models/user (#17781) 3 years ago
email_address.go Move more model into models/user (#17826) 3 years ago
email_address_test.go Move more model into models/user (#17826) 3 years ago
error.go Move user related model into models/user (#17781) 3 years ago
external_login_user.go Add Option to synchronize Admin & Restricted states from OIDC/OAuth2 along with Setting Scopes (#16766) 3 years ago
follow.go Remove NewSession method from db.Engine interface (#17577) 3 years ago
follow_test.go Move user follow and openid into models/user/ (#17613) 3 years ago
list.go Refactor auth package (#17962) 3 years ago
main_test.go Move user related model into models/user (#17781) 3 years ago
openid.go Move user follow and openid into models/user/ (#17613) 3 years ago
openid_test.go Move user follow and openid into models/user/ (#17613) 3 years ago
redirect.go Move EmailAddress & UserRedirect into models/user/ (#17607) 3 years ago
redirect_test.go Decouple unit test code from business code (#17623) 3 years ago
search.go Move user related model into models/user (#17781) 3 years ago
setting.go Simplify parameter types (#18006) 3 years ago
setting_test.go Add user settings key/value DB table (#16834) 3 years ago
user.go Increase Salt randomness (#18179) 3 years ago
user_test.go Refactor auth package (#17962) 3 years ago