You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2 years ago
..
install Improve install code to avoid low-level mistakes. (#17779) 3 years ago
paginator Use a struct as test options (#19393) 2 years ago
common.go Modify milestone search keywords to be case insensitive again (#20513) 2 years ago
consistency.go Move issues related files into models/issues (#19931) 2 years ago
context.go Fix various typos (#20338) 2 years ago
convert.go Refactor auth package (#17962) 3 years ago
engine.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
engine_test.go test: use `T.TempDir` to create temporary test directory (#21043) 2 years ago
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
index.go Refactor GetNextResourceIndex to make it work properly with transaction (#21469) 2 years ago
index_test.go Refactor GetNextResourceIndex to make it work properly with transaction (#21469) 2 years ago
iterate.go Add migrate repo archiver and packages storage support on command line (#20757) 2 years ago
list_options.go Add more linters to improve code readability (#19989) 2 years ago
log.go Allow manager logging to set SQL (#20064) 2 years ago
main_test.go Move tests as seperate sub packages to reduce duplicated file names (#19951) 2 years ago
name.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
search.go Move user related model into models/user (#17781) 3 years ago
sequence.go Move db related basic functions to models/db (#17075) 3 years ago
sql_postgres_with_schema.go Add more linters to improve code readability (#19989) 2 years ago