You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Refactor `modules/indexer` to make it more maintainable. And it can be easier to support more features. I'm trying to solve some of issue searching, this is a precursor to making functional changes. Current supported engines and the index versions: | engines | issues | code | | - | - | - | | db | Just a wrapper for database queries, doesn't need version | - | | bleve | The version of index is **2** | The version of index is **6** | | elasticsearch | The old index has no version, will be treated as version **0** in this PR | The version of index is **1** | | meilisearch | The old index has no version, will be treated as version **0** in this PR | - | ## Changes ### Split Splited it into mutiple packages ```text indexer ├── internal │ ├── bleve │ ├── db │ ├── elasticsearch │ └── meilisearch ├── code │ ├── bleve │ ├── elasticsearch │ └── internal └── issues ├── bleve ├── db ├── elasticsearch ├── internal └── meilisearch ``` - `indexer/interanal`: Internal shared package for indexer. - `indexer/interanal/[engine]`: Internal shared package for each engine (bleve/db/elasticsearch/meilisearch). - `indexer/code`: Implementations for code indexer. - `indexer/code/internal`: Internal shared package for code indexer. - `indexer/code/[engine]`: Implementation via each engine for code indexer. - `indexer/issues`: Implementations for issues indexer. ### Deduplication - Combine `Init/Ping/Close` for code indexer and issues indexer. - ~Combine `issues.indexerHolder` and `code.wrappedIndexer` to `internal.IndexHolder`.~ Remove it, use dummy indexer instead when the indexer is not ready. - Duplicate two copies of creating ES clients. - Duplicate two copies of `indexerID()`. ### Enhancement - [x] Support index version for elasticsearch issues indexer, the old index without version will be treated as version 0. - [x] Fix spell of `elastic_search/ElasticSearch`, it should be `Elasticsearch`. - [x] Improve versioning of ES index. We don't need `Aliases`: - Gitea does't need aliases for "Zero Downtime" because it never delete old indexes. - The old code of issues indexer uses the orignal name to create issue index, so it's tricky to convert it to an alias. - [x] Support index version for meilisearch issues indexer, the old index without version will be treated as version 0. - [x] Do "ping" only when `Ping` has been called, don't ping periodically and cache the status. - [x] Support the context parameter whenever possible. - [x] Fix outdated example config. - [x] Give up the requeue logic of issues indexer: When indexing fails, call Ping to check if it was caused by the engine being unavailable, and only requeue the task if the engine is unavailable. - It is fragile and tricky, could cause data losing (It did happen when I was doing some tests for this PR). And it works for ES only. - Just always requeue the failed task, if it caused by bad data, it's a bug of Gitea which should be fixed. --------- Co-authored-by: Giteabot <teabot@gitea.io> |
1 year ago | |
---|---|---|
.. | ||
actions | 1 year ago | |
activitypub | 1 year ago | |
analyze | 2 years ago | |
assetfs | 1 year ago | |
auth | 1 year ago | |
avatar | 1 year ago | |
base | 1 year ago | |
cache | 1 year ago | |
charset | 1 year ago | |
container | 2 years ago | |
context | 1 year ago | |
csv | 1 year ago | |
doctor | 1 year ago | |
emoji | 2 years ago | |
eventsource | 2 years ago | |
generate | 2 years ago | |
git | 1 year ago | |
gitgraph | 1 year ago | |
graceful | 1 year ago | |
hcaptcha | 2 years ago | |
highlight | 1 year ago | |
hostmatcher | 2 years ago | |
html | 2 years ago | |
httpcache | 1 year ago | |
httplib | 1 year ago | |
indexer | 1 year ago | |
issue/template | 2 years ago | |
json | 2 years ago | |
label | 1 year ago | |
lfs | 1 year ago | |
log | 1 year ago | |
markup | 1 year ago | |
mcaptcha | 2 years ago | |
metrics | 1 year ago | |
migration | 1 year ago | |
mirror | 1 year ago | |
nosql | 1 year ago | |
notification | 1 year ago | |
options | 1 year ago | |
packages | 1 year ago | |
paginator | 1 year ago | |
pprof | 2 years ago | |
private | 1 year ago | |
process | 1 year ago | |
proxy | 1 year ago | |
proxyprotocol | 2 years ago | |
public | 1 year ago | |
queue | 1 year ago | |
recaptcha | 2 years ago | |
references | 1 year ago | |
regexplru | 2 years ago | |
repository | 1 year ago | |
secret | 1 year ago | |
session | 1 year ago | |
setting | 1 year ago | |
sitemap | 2 years ago | |
ssh | 1 year ago | |
storage | 1 year ago | |
structs | 1 year ago | |
svg | 1 year ago | |
sync | 2 years ago | |
system | 2 years ago | |
templates | 1 year ago | |
test | 1 year ago | |
testlogger | 1 year ago | |
timeutil | 1 year ago | |
translation | 1 year ago | |
turnstile | 1 year ago | |
typesniffer | 1 year ago | |
updatechecker | 2 years ago | |
upload | 2 years ago | |
uri | 2 years ago | |
user | 2 years ago | |
util | 1 year ago | |
validation | 1 year ago | |
web | 1 year ago | |
webhook | 1 year ago |