You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/models
Jason Song 1e76a824bc
Refactor and enhance issue indexer to support both searching, filtering and paging (#26012)
Fix #24662.

Replace #24822 and #25708 (although it has been merged)


## Background

In the past, Gitea supported issue searching with a keyword and
conditions in a less efficient way. It worked by searching for issues
with the keyword and obtaining limited IDs (as it is heavy to get all)
on the indexer (bleve/elasticsearch/meilisearch), and then querying with
conditions on the database to find a subset of the found IDs. This is
why the results could be incomplete.

To solve this issue, we need to store all fields that could be used as
conditions in the indexer and support both keyword and additional
conditions when searching with the indexer.

## Major changes

- Redefine `IndexerData` to include all fields that could be used as
filter conditions.
- Refactor `Search(ctx context.Context, kw string, repoIDs []int64,
limit, start int, state string)` to `Search(ctx context.Context, options
*SearchOptions)`, so it supports more conditions now.
- Change the data type stored in `issueIndexerQueue`. Use
`IndexerMetadata` instead of `IndexerData` in case the data has been
updated while it is in the queue. This also reduces the storage size of
the queue.
- Enhance searching with Bleve/Elasticsearch/Meilisearch, make them
fully support `SearchOptions`. Also, update the data versions.
- Keep most logic of database indexer, but remove
`issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is
the entry point to search issues.
- Start a Meilisearch instance to test it in unit tests.
- Add unit tests with almost full coverage to test
Bleve/Elasticsearch/Meilisearch indexer.

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
11 months ago
..
actions Fix wrong workflow status when rerun a job in an already finished workflow (#26119) 12 months ago
activities Add context parameter to some database functions (#26055) 12 months ago
admin Replace `interface{}` with `any` (#25686) 1 year ago
asymkey Update tool dependencies, lock govulncheck and actionlint (#25655) 1 year ago
auth Remove "misc" scope check from public API endpoints (#26134) 12 months ago
avatars Avoid warning for system setting when start up (#23054) 1 year ago
db Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 11 months ago
dbfs Fix content holes in Actions task logs file (#25560) 1 year ago
fixtures Fix access check for org-level project (#26182) 11 months ago
git Fix pull request check list is limited (#26179) 11 months ago
issues Refactor and enhance issue indexer to support both searching, filtering and paging (#26012) 11 months ago
migrations Fix typo in metadata (#26207) 11 months ago
organization Remove unused code (#25734) 1 year ago
packages Test if container blob is accessible before mounting (#22759) 1 year ago
perm some less naked returns (#25682) 1 year ago
project Update xorm version (#26128) 12 months ago
pull refactor some functions to support ctx as first parameter (#21878) 2 years ago
repo Add commits dropdown in PR files view and allow commit by commit review (#25528) 11 months ago
secret Support configuration variables on Gitea Actions (#24724) 1 year ago
shared/types Display owner of a runner as a tooltip instead of static text (#24377) 1 year ago
system Replace `interface{}` with `any` (#25686) 1 year ago
unit Rewrite logger system (#24726) 1 year ago
unittest Replace `interface{}` with `any` (#25686) 1 year ago
user Fix API leaking Usermail if not logged in (#25097) 11 months ago
webhook Replace `interface{}` with `any` (#25686) 1 year ago
error.go Sync branches into databases (#22743) 1 year ago
fixture_generation.go Implement FSFE REUSE for golang files (#21840) 2 years ago
fixture_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
main_test.go Merge setting.InitXXX into one function with options (#24389) 1 year ago
migrate.go Add context parameter to some database functions (#26055) 12 months ago
migrate_test.go Add context parameter to some database functions (#26055) 12 months ago
org.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
org_team.go Remove org users who belong to no teams (#24247) 1 year ago
org_team_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
org_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo.go Update tool dependencies, lock govulncheck and actionlint (#25655) 1 year ago
repo_collaboration.go refactor some functions to support ctx as first parameter (#21878) 2 years ago
repo_collaboration_test.go Rename `repo.GetOwner` to `repo.LoadOwner` (#22967) 1 year ago
repo_test.go Implement FSFE REUSE for golang files (#21840) 2 years ago
repo_transfer.go Fix unclear `IsRepositoryExist` logic (#24374) 1 year ago
repo_transfer_test.go Rename almost all Ctx functions (#22071) 2 years ago