You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath fd15fd4c67
Handle too long PR titles correctly (#16517)
The CompareAndPullRequestPost handler for POST to /compare
incorrectly handles returning errors to the user. For a start
it does not set the necessary markers to switch SimpleMDE
but it also does not immediately return to the form.

This PR fixes this by setting the appropriate values, fixing
the templates and preventing the suggestion of a too long
title.

Fix #16507

Signed-off-by: Andrew Thornton <art27@cantab.net>
3 years ago
..
activity.go Refactor routers directory (#15800) 3 years ago
attachment.go Refactor routers directory (#15800) 3 years ago
blame.go Link to previous blames in file blame page (#16259) 3 years ago
branch.go Let package git depend on setting but not opposite (#15241) 3 years ago
commit.go Let package git depend on setting but not opposite (#15241) 3 years ago
compare.go Handle too long PR titles correctly (#16517) 3 years ago
download.go Refactor routers directory (#15800) 3 years ago
editor.go Add an abstract json layout to make it's easier to change json library (#16528) 3 years ago
editor_test.go Refactor routers directory (#15800) 3 years ago
http.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
http_test.go Fix http path bug (#16117) 3 years ago
issue.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
issue_dependency.go Refactor routers directory (#15800) 3 years ago
issue_label.go Refactor routers directory (#15800) 3 years ago
issue_label_test.go Refactor routers directory (#15800) 3 years ago
issue_lock.go Refactor routers directory (#15800) 3 years ago
issue_stopwatch.go Refactor routers directory (#15800) 3 years ago
issue_test.go Refactor routers directory (#15800) 3 years ago
issue_timetrack.go Refactor routers directory (#15800) 3 years ago
issue_watch.go Refactor routers directory (#15800) 3 years ago
lfs.go Refactor routers directory (#15800) 3 years ago
main_test.go Refactor routers directory (#15800) 3 years ago
middlewares.go Refactor routers directory (#15800) 3 years ago
migrate.go Add push to remote mirror repository (#15157) 3 years ago
milestone.go More efficiently parse shas for shaPostProcessor (#16101) 3 years ago
projects.go More efficiently parse shas for shaPostProcessor (#16101) 3 years ago
projects_test.go Refactor routers directory (#15800) 3 years ago
pull.go Handle too long PR titles correctly (#16517) 3 years ago
pull_review.go Add attachments for PR reviews (#16075) 3 years ago
release.go Add tag protection (#15629) 3 years ago
release_test.go Refactor routers directory (#15800) 3 years ago
repo.go Rework repository archive (#14723) 3 years ago
search.go Refactor routers directory (#15800) 3 years ago
setting.go Add checkbox to delete pull branch after successful merge (#16049) 3 years ago
setting_protected_branch.go Refactor routers directory (#15800) 3 years ago
settings_test.go Refactor routers directory (#15800) 3 years ago
tag.go Add tag protection (#15629) 3 years ago
topic.go Refactor routers directory (#15800) 3 years ago
view.go Fix external renderer (#16401) 3 years ago
webhook.go Add an abstract json layout to make it's easier to change json library (#16528) 3 years ago
wiki.go Let package git depend on setting but not opposite (#15241) 3 years ago
wiki_test.go Add TestPrepareWikiFileName (#16487) 3 years ago