#7 fail gracefully if gitea url violates RFC 2606

This commit is contained in:
Tobias Trabelsi 2022-08-04 18:23:41 +02:00
parent 1c8d5146fb
commit edfd4e2e06
No known key found for this signature in database
GPG key ID: FF0C2839718CAF2E
4 changed files with 6 additions and 3 deletions

View file

@ -3,7 +3,7 @@ GOFMT_FILES?=$$(find . -name '*.go' |grep -v vendor)
GOFMT ?= gofmt -s
VERSION = 0.6.1
VERSION = 0.7.0
test: fmt-check
go test -i $(TEST) || exit 1

View file

@ -17,7 +17,7 @@ terraform {
required_providers {
gitea = {
source = "Lerentis/gitea"
version = "0.6.1"
version = "0.7.0"
}
}
}

View file

@ -2,7 +2,7 @@ terraform {
required_providers {
gitea = {
source = "terraform.local/lerentis/gitea"
version = "0.6.1"
version = "0.7.0"
}
}
}

View file

@ -118,5 +118,8 @@ func validateAPIURLVersion(value interface{}, key string) (ws []string, es []err
if strings.HasSuffix(v, "/api/v1") || strings.HasSuffix(v, "/api/v1/") {
es = append(es, fmt.Errorf("terraform-gitea-provider base URL format is incorrect; Please leave out API Path %s", v))
}
if strings.Contains(v, "localhost") && strings.Contains(v, ".") {
es = append(es, fmt.Errorf("terraform-gitea-provider base URL violates RFC 2606; Please do not define a subdomain for localhost!"))
}
return
}