meissa/dda-devops-build
6
1
Fork 0
Code Issues Pull requests Projects Releases 33 Packages Wiki Activity

Remove todos

Browse source
This commit is contained in:
patdyn 2024-06-27 14:19:27 +02:00
parent 872b29179e
commit 07169c5b3d
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/main/python/ddadevops/domain/backend_tf_backend_git.py
View file

@ -1,8 +1,7 @@
from typing import List, Dict, Set, Any from typing import List, Dict, Set, Any
from .common import Validateable, CredentialMappingDefault from .common import Validateable, CredentialMappingDefault
# TODO: Add a 'git_as_backend' option
# TODO: Check this option at the right places
class TerraformBackendGit(Validateable, CredentialMappingDefault): class TerraformBackendGit(Validateable, CredentialMappingDefault):
def __init__( def __init__(
self, self,
@ -40,10 +39,11 @@ class TerraformBackendGit(Validateable, CredentialMappingDefault):
def resources_from_package(self) -> Set[str]: def resources_from_package(self) -> Set[str]:
return {"tf_backend_git_backend.tf", "tf_backend_git_backend_vars.tf"} return {"tf_backend_git_backend.tf", "tf_backend_git_backend_vars.tf"}
# TODO: This can not be used for backend config, as the backend block can not reference vars. # TODO: This can not be used for backend, as the backend block can not reference vars.
# This is another reason to introduce a 'backend' object
def project_vars(self) -> Dict[str, Any]: def project_vars(self) -> Dict[str, Any]:
return { return {
"http_backend_address": self.__make_http_backend_address__() "": ""
} }
def is_local_state(self): def is_local_state(self):

1
src/main/python/ddadevops/domain/terraform.py
View file

@ -95,7 +95,6 @@ class TerraformDomain(Validateable):
return False return False
# TODO: Add ssh method case and make this default # TODO: Add ssh method case and make this default
# TODO: How do we get to the credentials?
def env_credentials(self) -> Dict[str, str]: def env_credentials(self) -> Dict[str, str]:
tf_backend_git = self.providers[ProviderType.TERRAFORM_BACKEND_GIT] tf_backend_git = self.providers[ProviderType.TERRAFORM_BACKEND_GIT]
if tf_backend_git.git_backend_token != "": if tf_backend_git.git_backend_token != "":