Add review comments for version

This commit is contained in:
bom 2023-05-11 15:20:49 +02:00
parent 64116edcb4
commit 6766691ee7

View file

@ -99,10 +99,12 @@ def test_should_create_major():
assert sut.to_string() == "2.0.0" assert sut.to_string() == "2.0.0"
def test_should_create_bump(): def test_should_create_bump():
# TODO: bom - 2023_05_11: Why does this not actually bump the version?
version = Version.from_str("1.2.3-SNAPSHOT") version = Version.from_str("1.2.3-SNAPSHOT")
sut = version.create_bump() sut = version.create_bump()
assert sut.to_string() == "1.2.3-SNAPSHOT" assert sut.to_string() == "1.2.3-SNAPSHOT"
# TODO: bom - 2023_05_11: Why do we bump the minor version and not the patch?
version = Version.from_str("1.2.3") version = Version.from_str("1.2.3")
sut = version.create_bump("SNAPSHOT") sut = version.create_bump("SNAPSHOT")
assert sut.to_string() == "1.3.0-SNAPSHOT" assert sut.to_string() == "1.3.0-SNAPSHOT"