add some todos
This commit is contained in:
parent
e927ec9fcf
commit
8ce3c74c34
1 changed files with 4 additions and 0 deletions
|
@ -101,6 +101,9 @@ class ExecutionApi:
|
|||
output = output.rstrip()
|
||||
return output
|
||||
|
||||
# TODO: check for exception handling
|
||||
# TODO: can we return the output here also?
|
||||
# TODO: should we also print stderr?
|
||||
def execute_live(self, command: str, dry_run=False, shell=True):
|
||||
if dry_run:
|
||||
print(command)
|
||||
|
@ -111,6 +114,7 @@ class ExecutionApi:
|
|||
process.stdout.close()
|
||||
process.wait()
|
||||
|
||||
# TODO: move this enhancement to execute
|
||||
def execute_handled(self, command: str, dry_run=False, shell=True, check=True):
|
||||
if dry_run:
|
||||
print(command)
|
||||
|
|
Loading…
Reference in a new issue