You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
1 year ago
..
actions Implement actions artifacts (#22738) 1 year ago
branch Improve button-ghost, remove tertiary button (#24692) 1 year ago
cite Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 1 year ago
diff Improve accessibility when (re-)viewing files (#24817) 1 year ago
editor Remove fomantic breadcrumb module (#24463) 1 year ago
find Refactor hiding-methods, remove jQuery show/hide, remove `.hide` class, remove inline style=display:none (#22950) 1 year ago
graph Improve commit date in commit graph (#24399) 1 year ago
issue Improve accessibility when (re-)viewing files (#24817) 1 year ago
migrate Rework Oauth login buttons, swap github logo to monocolor (#24740) 1 year ago
projects Update pin and add pin-slash (#24669) 1 year ago
pulls Make diff view full width again (#24598) 1 year ago
release RSS icon fixes (#24476) 1 year ago
settings Support for status check pattern (#24633) 1 year ago
tag RSS icon fixes (#24476) 1 year ago
wiki Don't display creating page button in a mirror wiki repository (#24395) 1 year ago
activity.tmpl Fix template function DateTime (#24317) 1 year ago
blame.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
branch_dropdown.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 1 year ago
clone_buttons.tmpl Clean template/helper.go (#23922) 1 year ago
clone_script.tmpl Clean template/helper.go (#23922) 1 year ago
commit_page.tmpl Improve some modal action buttons (#24289) 1 year ago
commit_status.tmpl Use different SVG for pending and running actions (#23836) 1 year ago
commit_statuses.tmpl Fix hidden commit status on multiple checks (#22889) 1 year ago
commits.tmpl Make Issue/PR/projects more compact, misc CSS tweaks (#24459) 1 year ago
commits_list.tmpl Add context when rendering labels or emojis (#23281) 1 year ago
commits_list_small.tmpl Clean up various avatar dimensions (#24701) 1 year ago
commits_table.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
create.tmpl Make label templates have consistent behavior and priority (#23749) 1 year ago
create_helper.tmpl Add templates to customize text when creating and migrating repositories 2 years ago
empty.tmpl Display when a repo was archived (#22664) 1 year ago
file_info.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
forks.tmpl Remove fomantic ".link" selector and styles (#23888) 1 year ago
graph.tmpl Replace remaining fontawesome dropdown icons with SVG (#24455) 1 year ago
header.tmpl Refactor Pull Mirror and fix out-of-sync bugs (#24732) 1 year ago
home.tmpl Improve button-ghost, remove tertiary button (#24692) 1 year ago
icon.tmpl Move helpers to be prefixed with `gt-` (#22879) 1 year ago
packages.tmpl Add main landmark to templates and adjust titles (#22670) 2 years ago
release_tag_header.tmpl Remove svg.svg class, restore .rss-icon (#24667) 1 year ago
search.tmpl Use data-tooltip-content for tippy tooltip (#23649) 1 year ago
search_name.tmpl Clean template/helper.go (#23922) 1 year ago
shabox_badge.tmpl Fix shabox regression (#22924) 1 year ago
sub_menu.tmpl Make repo size style matches others (commits/branches/tags) (#24408) 1 year ago
unicode_escape_prompt.tmpl Convert `<div class="button">` to `<button class="button">` (#23337) 1 year ago
upload.tmpl Refactor `i18n` to `locale` (#20153) 2 years ago
user_cards.tmpl Change `join_on` translation to `joined_on` and include placeholder for the date (#24550) 1 year ago
view_file.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
view_list.tmpl Improve template helper (#24417) 1 year ago
watchers.tmpl Fix user-cards format (#24428) 1 year ago