You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
delvh e95b42e187
Improve accessibility when (re-)viewing files (#24817)
Visually, nothing should have changed.
Changes include
- Convert most `<a [no href]>` to `<button>` when (re-)viewing files:
- `<a [no href]>` are, by HTML definition, not a link and hence cannot
be focused
- `<a class="ui button">` can now be clicked (again?) using
<kbd>Enter</kbd>
- Previously, the installed keypress handler on `.ui.button` elements
disabled it for links somehow
- The `(un)escape file`, the `expand section` and the `expand/collapse
file` buttons can now be focused (and subsequently clicked using only
the keyboard)
- You can now press <kbd>Space</kbd> on a focused `View file` checkbox
to mark the file as viewed.
- previously, this was impossible as this checkbox listened on the wrong
event listener

The `add code comment` button has been left inaccessible for now as it
requires quite a bit of extra logic so that it is unhidden when it is
focused (you can otherwise focus it without seeing it as you are not
hovering on the corresponding line).

---------

Co-authored-by: silverwind <me@silverwind.io>
1 year ago
..
blob_excerpt.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
box.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
comment_form.tmpl Introduce GitHub markdown editor, keep EasyMDE as fallback (#23876) 1 year ago
comment_form_datahandler.tmpl Make sure fmt catches all templates (#20979) 2 years ago
comments.tmpl Fix issue attachment handling (#24202) 1 year ago
compare.tmpl Remove fluid on compare diff page (#24627) 1 year ago
conversation.tmpl Start cleaning the messy ".ui.left / .ui.right", improve label list page, fix stackable menu (#24393) 1 year ago
csv_diff.tmpl Fix CSV diff for added/deleted files (#21189) 2 years ago
escape_title.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2 years ago
image_diff.tmpl Improve "new-menu" (#24465) 1 year ago
new_comment.tmpl Do not reload page after adding comments in Pull Request reviews (#13877) 4 years ago
new_review.tmpl Add markdown preview to Submit Review Textarea (#24672) 1 year ago
options_dropdown.tmpl Expand/Collapse all changed files (#23639) 1 year ago
section_code.tmpl Switch Unicode Escaping to a VSCode-like system (#19990) 2 years ago
section_split.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
section_unified.tmpl Improve accessibility when (re-)viewing files (#24817) 1 year ago
stats.tmpl Group template helper functions, remove `Printf`, improve template error messages (#23982) 1 year ago
whitespace_dropdown.tmpl Fix incorrect `toggle` buttons (#23676) 1 year ago