You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
forgejo/modules
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2 years ago
..
activitypub Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
analyze Simplify `IsVendor` (#19626) 2 years ago
auth Remove legacy `+build:` constraint (#19582) 2 years ago
avatar Go 1.19 format (#20758) 2 years ago
base Add generic set type (#21408) 2 years ago
cache Update go-chi/cache to utilize Ping() (#19719) 2 years ago
charset Move go-licenses to generate and separate generate into a frontend and backend component (#21061) 2 years ago
container Add generic set type (#21408) 2 years ago
context Redirect to new repository owner (#21398) 2 years ago
convert Use Name instead of DisplayName in LFS Lock (#21415) 2 years ago
csv Go 1.19 format (#20758) 2 years ago
doctor Add HEAD fix to gitea doctor (#21352) 2 years ago
emoji Go 1.19 format (#20758) 2 years ago
eventsource Move some files into models' sub packages (#20262) 2 years ago
generate Use base32 for 2FA scratch token (#18384) 2 years ago
git Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
gitgraph alternative to PR "improve code quality" (#21464) 2 years ago
graceful Support Proxy protocol (#12527) 2 years ago
hcaptcha hCaptcha Support (#12594) 4 years ago
highlight Upgrade chroma to v2.3.0 (#21259) 2 years ago
hostmatcher Add proxy host into allow list (#20798) 2 years ago
httpcache Add Cache-Control header to html and api responses, add no-transform (#20432) 2 years ago
httplib refactor httplib (#18338) 2 years ago
indexer test: use `T.TempDir` to create temporary test directory (#21043) 2 years ago
issue/template Add generic set type (#21408) 2 years ago
json Refactor legacy `unknwon/com` package, improve golangci lint (#19284) 2 years ago
lfs Removed some vestigial code related to Range bounds checks (#20312) 2 years ago
log test: use `T.TempDir` to create temporary test directory (#21043) 2 years ago
markup Add generic set type (#21408) 2 years ago
mcaptcha Add support mCaptcha as captcha provider (#20458) 2 years ago
metrics Move some files into models' sub packages (#20262) 2 years ago
migration Add more checks in migration code (#21011) 2 years ago
mirror Implement sync push mirror on commit (#19411) 2 years ago
nosql fix broken insecureskipverify handling in rediss connection uris (#20967) 2 years ago
notification Display total commit count in hook message (#21400) 2 years ago
options Fix and improve incorrect error messages (#21342) 2 years ago
packages Add support for Chocolatey/NuGet v2 API (#21393) 2 years ago
paginator Remove legacy unmaintained packages, refactor to support change default locale (#19308) 2 years ago
password Fixed assert statements. (#16089) 3 years ago
pprof Go 1.19 format (#20758) 2 years ago
private log real ip of requests from ssh (#21216) 2 years ago
process Add more linters to improve code readability (#19989) 2 years ago
proxy Return nil proxy function if proxy not enabled (#16742) 3 years ago
proxyprotocol Support Proxy protocol (#12527) 2 years ago
public Add generic set type (#21408) 2 years ago
queue Add generic set type (#21408) 2 years ago
recaptcha refactor: move from io/ioutil to io and os package (#17109) 3 years ago
references Add more linters to improve code readability (#19989) 2 years ago
regexplru Custom regexp external issues (#17624) 2 years ago
repository Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
secret Use `CryptoRandomBytes` instead of `CryptoRandomString` (#18439) 2 years ago
session format with gofumpt (#18184) 2 years ago
setting Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
sitemap Add sitemap support (#18407) 2 years ago
ssh Support Proxy protocol (#12527) 2 years ago
storage Save files in local storage as umask (#21198) 2 years ago
structs Display total commit count in hook message (#21400) 2 years ago
svg Remove legacy `+build:` constraint (#19582) 2 years ago
sync Add generic set type (#21408) 2 years ago
system Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
templates Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
test Refactor AssertExistsAndLoadBean to use generics (#20797) 2 years ago
timeutil Share HTML template renderers and create a watcher framework (#20218) 2 years ago
translation Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
typesniffer Rework raw file http header logic (#20484) 2 years ago
updatechecker Add system setting table with cache and also add cache supports for user setting (#18058) 2 years ago
upload Simplify parameter types (#18006) 3 years ago
uri Prevent NPE if gitea uploader fails to open url (#18080) 3 years ago
user Add gitea-vet (#10948) 4 years ago
util Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
validation Add more checks in migration code (#21011) 2 years ago
watcher Share HTML template renderers and create a watcher framework (#20218) 2 years ago
web refactor webhook *NewPost (#20729) 2 years ago