You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
zeripath 716fcfcf72
Make every not exist error unwrappable to a fs.ErrNotExist (#20891)
A lot of our code is repeatedly testing if individual errors are
specific types of Not Exist errors. This is repetitative and unnecesary.
`Unwrap() error` provides a common way of labelling an error as a
NotExist error and we can/should use this.

This PR has chosen to use the common `io/fs` errors e.g.
`fs.ErrNotExist` for our errors. This is in some ways not completely
correct as these are not filesystem errors but it seems like a
reasonable thing to do and would allow us to simplify a lot of our code
to `errors.Is(err, fs.ErrNotExist)` instead of
`package.IsErr...NotExist(err)`

I am open to suggestions to use a different base error - perhaps
`models/db.ErrNotExist` if that would be felt to be better.


Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: delvh <dev.lh@web.de>
2 years ago
..
filebuffer Fix package upload for files >32mb (#20622) 2 years ago
compare.go Simplify parameter types (#18006) 3 years ago
error.go Make every not exist error unwrappable to a fs.ErrNotExist (#20891) 2 years ago
file_unix.go Save files in local storage as umask (#21198) 2 years ago
file_unix_test.go Save files in local storage as umask (#21198) 2 years ago
file_windows.go Save files in local storage as umask (#21198) 2 years ago
io.go Add more linters to improve code readability (#19989) 2 years ago
legacy.go Remove legacy `unknwon/com` package (#19298) 2 years ago
legacy_test.go Remove legacy `unknwon/com` package (#19298) 2 years ago
paginate.go [API] Add pagination to ListBranches (#14524) 3 years ago
paginate_test.go format with gofumpt (#18184) 2 years ago
path.go Share HTML template renderers and create a watcher framework (#20218) 2 years ago
path_test.go format with gofumpt (#18184) 2 years ago
remove.go Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) 3 years ago
sanitize.go Use a more general (and faster) method to sanitize URLs with credentials (#19239) 2 years ago
sanitize_test.go Use a more general (and faster) method to sanitize URLs with credentials (#19239) 2 years ago
sec_to_time.go Fix SecToTime edge-cases (#20610) 2 years ago
sec_to_time_test.go Fix SecToTime edge-cases (#20610) 2 years ago
shellquote.go format with gofumpt (#18184) 2 years ago
shellquote_test.go Fix various documentation, user-facing, and source comment typos (#16367) 3 years ago
slice.go Cleanup protected branches when deleting users & teams (#19158) 2 years ago
string.go Go 1.19 format (#20758) 2 years ago
string_test.go Remove legacy `unknwon/com` package (#19298) 2 years ago
timer.go Prevent timer leaks in Workerpool and others (#11333) 4 years ago
truncate.go format with gofumpt (#18184) 2 years ago
truncate_test.go Fix a panic in NotifyCreateIssueComment (caused by string truncation) (#17928) 3 years ago
url.go Re-attempt to delete temporary upload if the file is locked by another process (#12447) 4 years ago
util.go Prettify number of issues (#17760) 2 years ago
util_test.go Fix copy/paste of empty lines (#19798) 2 years ago